Reuse existing paint property node is possible

third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/paint/PaintArtifactToSkCanvas.h"
 
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/graphics/paint/DisplayItem.h"
 #include "platform/graphics/paint/DrawingDisplayItem.h"
 #include "platform/graphics/paint/PaintArtifact.h"
@@ skipping 102 matching lines @@
         EXPECT_CALL(canvas, onDrawRect(SkRect::MakeWH(300, 200), Property(&SkPaint::getColor, SK_ColorRED),
             Pointee(Property(&SkCanvas::getTotalMatrix, adjustedScale))));
         EXPECT_CALL(canvas, onDrawRect(SkRect::MakeWH(300, 200), Property(&SkPaint::getColor, SK_ColorBLUE),
             Pointee(Property(&SkCanvas::getTotalMatrix, combinedMatrix))));
     }
 
     // Build the transform tree.
     TransformationMatrix matrix1;
     matrix1.scale(2);
     FloatPoint3D origin1(10, 10, 0);
-    RefPtr<TransformPaintPropertyNode> transform1 = TransformPaintPropertyNode::create(matrix1, origin1);
+    RefPtr<TransformPaintPropertyNode> transform1 = TransformPaintPropertyNode::create(nullptr, matrix1, origin1);
     TransformationMatrix matrix2;
     matrix2.translate(5, 5);
-    RefPtr<TransformPaintPropertyNode> transform2 = TransformPaintPropertyNode::create(matrix2, FloatPoint3D(), transform1.get());
+    RefPtr<TransformPaintPropertyNode> transform2 = TransformPaintPropertyNode::create(transform1, matrix2, FloatPoint3D());
 
     TestPaintArtifact artifact;
     artifact.chunk(transform1.get(), nullptr, nullptr)
         .rectDrawing(FloatRect(0, 0, 300, 200), SK_ColorRED);
     artifact.chunk(transform2.get(), nullptr, nullptr)
         .rectDrawing(FloatRect(0, 0, 300, 200), SK_ColorBLUE);
     paintArtifactToSkCanvas(artifact.build(), &canvas);
 }
 
 TEST_F(PaintArtifactToSkCanvasTest, OpacityEffectsCombining)
 {
     unsigned expectedFirstOpacity = 127; // floor(0.5 * 255)
     unsigned expectedSecondOpacity = 63; // floor(0.25 * 255)
     MockCanvas canvas(kCanvasWidth, kCanvasHeight);
     {
         testing::InSequence sequence;
         EXPECT_CALL(canvas, willSaveLayer(expectedFirstOpacity, _));
         EXPECT_CALL(canvas, onDrawRect(SkRect::MakeWH(300, 200), Property(&SkPaint::getColor, SK_ColorRED), _));
         EXPECT_CALL(canvas, willSaveLayer(expectedSecondOpacity, _));
         EXPECT_CALL(canvas, onDrawRect(SkRect::MakeWH(300, 200), Property(&SkPaint::getColor, SK_ColorBLUE), _));
     }
 
     // Build an opacity effect tree.
-    RefPtr<EffectPaintPropertyNode> opacityEffect1 = EffectPaintPropertyNode::create(0.5);
-    RefPtr<EffectPaintPropertyNode> opacityEffect2 = EffectPaintPropertyNode::create(0.25, opacityEffect1);
+    RefPtr<EffectPaintPropertyNode> opacityEffect1 = EffectPaintPropertyNode::create(nullptr, 0.5);
+    RefPtr<EffectPaintPropertyNode> opacityEffect2 = EffectPaintPropertyNode::create(opacityEffect1, 0.25);
 
     TestPaintArtifact artifact;
     artifact.chunk(nullptr, nullptr, opacityEffect1.get())
         .rectDrawing(FloatRect(0, 0, 300, 200), SK_ColorRED);
     artifact.chunk(nullptr, nullptr, opacityEffect2.get())
         .rectDrawing(FloatRect(0, 0, 300, 200), SK_ColorBLUE);
     paintArtifactToSkCanvas(artifact.build(), &canvas);
 }
 
 TEST_F(PaintArtifactToSkCanvasTest, ChangingOpacityEffects)
@@ skipping 12 matching lines @@
         EXPECT_CALL(canvas, willSaveLayer(expectedDOpacity, _));
         EXPECT_CALL(canvas, onDrawRect(SkRect::MakeWH(300, 200), Property(&SkPaint::getColor, SK_ColorBLUE), _));
     }
 
     // Build an opacity effect tree with the following structure:
     //       _root_
     //      |      |
     // 0.1  a      c  0.3
     //      |      |
     // 0.2  b      d  0.4
-    RefPtr<EffectPaintPropertyNode> opacityEffectA = EffectPaintPropertyNode::create(0.1);
-    RefPtr<EffectPaintPropertyNode> opacityEffectB = EffectPaintPropertyNode::create(0.2, opacityEffectA);
-    RefPtr<EffectPaintPropertyNode> opacityEffectC = EffectPaintPropertyNode::create(0.3);
-    RefPtr<EffectPaintPropertyNode> opacityEffectD = EffectPaintPropertyNode::create(0.4, opacityEffectC);
+    RefPtr<EffectPaintPropertyNode> opacityEffectA = EffectPaintPropertyNode::create(nullptr, 0.1);
+    RefPtr<EffectPaintPropertyNode> opacityEffectB = EffectPaintPropertyNode::create(opacityEffectA, 0.2);
+    RefPtr<EffectPaintPropertyNode> opacityEffectC = EffectPaintPropertyNode::create(nullptr, 0.3);
+    RefPtr<EffectPaintPropertyNode> opacityEffectD = EffectPaintPropertyNode::create(opacityEffectC, 0.4);
 
     // Build a two-chunk artifact directly.
     // chunk1 references opacity node b, chunk2 references opacity node d.
     TestPaintArtifact artifact;
     artifact.chunk(nullptr, nullptr, opacityEffectB.get())
         .rectDrawing(FloatRect(0, 0, 300, 200), SK_ColorRED);
     artifact.chunk(nullptr, nullptr, opacityEffectD.get())
         .rectDrawing(FloatRect(0, 0, 300, 200), SK_ColorBLUE);
     paintArtifactToSkCanvas(artifact.build(), &canvas);
 }
@@ skipping 15 matching lines @@
     //     <div style="position:fixed; left:150px; top:150px; width:100px; height:100px; overflow:hidden;">
     //         client1
     //     </div>
     // </div>
     // <script>scrollTo(0, 100)</script>
     // The content itself will not be scrolled due to fixed positioning,
     // but will be affected by some scrolled clip.
 
     // Setup transform tree.
     RefPtr<TransformPaintPropertyNode> transform1 = TransformPaintPropertyNode::create(
-        TransformationMatrix().translate(0, -100), FloatPoint3D());
+        nullptr, TransformationMatrix().translate(0, -100), FloatPoint3D());
 
     // Setup clip tree.
     RefPtr<ClipPaintPropertyNode> clip1 = ClipPaintPropertyNode::create(
-        transform1.get(), FloatRoundedRect(100, 200, 100, 100));
+        nullptr, transform1.get(), FloatRoundedRect(100, 200, 100, 100));
     RefPtr<ClipPaintPropertyNode> clip2 = ClipPaintPropertyNode::create(
-        nullptr, FloatRoundedRect(150, 150, 100, 100), clip1.get());
+        clip1, nullptr, FloatRoundedRect(150, 150, 100, 100));
 
     MockCanvas canvas(kCanvasWidth, kCanvasHeight);
 
     SkRegion totalClip;
     totalClip.setRect(SkIRect::MakeXYWH(100, 100, 100, 100));
     totalClip.op(SkIRect::MakeXYWH(150, 150, 100, 100), SkRegion::kIntersect_Op);
     EXPECT_CALL(canvas, onDrawRect(SkRect::MakeWH(300, 200), Property(&SkPaint::getColor, SK_ColorRED),
         ResultOf(&getCanvasClipAsRegion, Eq(totalClip))));
 
     TestPaintArtifact artifact;
     artifact.chunk(nullptr, clip2.get(), nullptr)
         .rectDrawing(FloatRect(0, 0, 300, 200), SK_ColorRED);
     paintArtifactToSkCanvas(artifact.build(), &canvas);
 }
 
 } // namespace
 } // namespace blink