Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2144813003: Add tests for annotations. (Closed)

Created:
4 years, 5 months ago by jaepark
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for annotations. Current expected files are not drawing annotations. It should be updated as we enable drawing annotations. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/d307839b3d4c8e521208172155718c945af696e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A pdfium/annots/annotation_circle.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_circle_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/annots/annotation_freetext.pdf View Binary file 0 comments Download
A pdfium/annots/annotation_freetext_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/annots/annotation_highlight.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_highlight_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/annots/annotation_ink.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_ink_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/annots/annotation_polygon.pdf View Binary file 0 comments Download
A pdfium/annots/annotation_polygon_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/annots/annotation_square.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_square_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/annots/annotation_squiggly.pdf View Binary file 0 comments Download
A pdfium/annots/annotation_squiggly_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/annots/annotation_stamp.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_stamp_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/annots/annotation_strikeout.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_strikeout_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/annots/annotation_text.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_text_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/annots/annotation_underline.pdf View Binary file 0 comments Download
A pdfium/annots/annotation_underline_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 5 (2 generated)
jaepark
4 years, 5 months ago (2016-07-12 23:13:46 UTC) #2
Lei Zhang
lgtm Corpus tests pass on win/mac/linux for me.
4 years, 5 months ago (2016-07-12 23:56:23 UTC) #3
jaepark
4 years, 5 months ago (2016-07-13 00:17:01 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d307839b3d4c8e521208172155718c945af696e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698