Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: src/codegen-ia32.cc

Issue 21448: Experimental: for the inlined keyed load IC, change the base address... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/toiger/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ic-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen-ia32.cc
===================================================================
--- src/codegen-ia32.cc (revision 1295)
+++ src/codegen-ia32.cc (working copy)
@@ -4805,12 +4805,6 @@
// it in the IC initialization code and patch the cmp instruction.
// This means that we cannot allow test instructions after calls to
// KeyedLoadIC stubs in other places.
- //
- // The virtual frame should be spilled fully before the call so that
- // the call itself does not generate extra code to spill values,
- // which would invalidate the delta calculation.
- cgen->frame()->SpillAll();
- int delta_to_patch_site = __ SizeOfCodeGeneratedSince(patch_site());
Result value(cgen);
if (is_global_) {
value = cgen->frame()->CallCodeObject(ic,
@@ -4823,6 +4817,9 @@
// offset to the patch site will be expected in a test eax
// instruction.
ASSERT(value.is_register() && value.reg().is(eax));
+ // The delta from the start of the map-compare instruction to the
+ // test eax instruction.
+ int delta_to_patch_site = __ SizeOfCodeGeneratedSince(patch_site());
__ test(value.reg(), Immediate(-delta_to_patch_site));
__ IncrementCounter(&Counters::keyed_load_inline_miss, 1);
exit()->Jump(&value);
« no previous file with comments | « no previous file | src/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698