Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2144783002: mash: Move MultiProfileMediaTrayItem to ash/common. (Closed)

Created:
4 years, 5 months ago by msw
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move MultiProfileMediaTrayItem to ash/common. BUG=619636 TEST=compiles; unit tests; no behavior changes. R=jamescook@chromium.org Committed: https://crrev.com/02c8884742acf6ae4e33550188c8bcaac3212166 Cr-Commit-Position: refs/heads/master@{#404950}

Patch Set 1 #

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -127 lines) Patch
M ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/common/system/chromeos/media_security/multi_profile_media_tray_item.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
A + ash/common/system/chromeos/media_security/multi_profile_media_tray_item.cc View 3 chunks +3 lines, -3 lines 0 comments Download
D ash/system/chromeos/media_security/multi_profile_media_tray_item.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ash/system/chromeos/media_security/multi_profile_media_tray_item.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M ash/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
msw
Hey James, please take a look; thanks!
4 years, 5 months ago (2016-07-12 20:31:18 UTC) #1
James Cook
LGTM. Can you add this test to the list at http://crbug.com/620955 with a brief note ...
4 years, 5 months ago (2016-07-12 23:33:12 UTC) #6
msw
On 2016/07/12 23:33:12, James Cook wrote: > Can you add this test to the list ...
4 years, 5 months ago (2016-07-13 00:59:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144783002/20001
4 years, 5 months ago (2016-07-13 01:04:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 03:20:02 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:23:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02c8884742acf6ae4e33550188c8bcaac3212166
Cr-Commit-Position: refs/heads/master@{#404950}

Powered by Google App Engine
This is Rietveld 408576698