Issue 26249. Quick Assist to convert getters into final fields.

Issue 26249. Quick Assist to convert getters into final fields.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26249

Committed: https://github.com/dart-lang/sdk/commit/f1fa32e3563c29a8abccb77bf79b3b4320dae204

[Brian Wilkerson, 2016-07-12 19:52:24]

https://codereview.chromium.org/2144763002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/2144763002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:501: // The
getter body must be an expression.
We could eventually support block function bodies with a single return
statement, but I don't think it's critical for now.

https://codereview.chromium.org/2144763002/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/correction/assist_test.dart (right):

https://codereview.chromium.org/2144763002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/correction/assist_test.dart:1435:
test_convertToFinalField_BAD_notExpressionBody() async {
What about

class A {
  int get foo => 3;
  set foo(int x) {}
}

Seems like we should only offer the assist if there is no setter.

Should we support the same operation for top-level getters?

[scheglov, 2016-07-12 20:26:28]

PTAL

https://codereview.chromium.org/2144763002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/2144763002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:501: // The
getter body must be an expression.
On 2016/07/12 19:52:24, Brian Wilkerson wrote:
> We could eventually support block function bodies with a single return
> statement, but I don't think it's critical for now.

Done.

https://codereview.chromium.org/2144763002/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/correction/assist_test.dart (right):

https://codereview.chromium.org/2144763002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/correction/assist_test.dart:1435:
test_convertToFinalField_BAD_notExpressionBody() async {
On 2016/07/12 19:52:24, Brian Wilkerson wrote:
> What about
> 
> class A {
>   int get foo => 3;
>   set foo(int x) {}
> }
> 
> Seems like we should only offer the assist if there is no setter.

Thank you.
Fixed.

> 
> Should we support the same operation for top-level getters?

Maybe, but it's slightly different implementation, and it's not so often used
IMHO.
So, not now.

[Brian Wilkerson, 2016-07-12 20:29:05]

lgtm

[scheglov, 2016-07-12 20:31:58]

Description was changed from

==========
Issue 26249. Quick Assist to convert getters into final fields.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26249
==========

to

==========
Issue 26249. Quick Assist to convert getters into final fields.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26249

Committed:
https://github.com/dart-lang/sdk/commit/f1fa32e3563c29a8abccb77bf79b3b4320dae204
==========

[scheglov, 2016-07-12 20:32:00]

Committed patchset #2 (id:20001) manually as
f1fa32e3563c29a8abccb77bf79b3b4320dae204 (presubmit successful).