Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2144753002: Remove views::SingleSplitView as it's presently unused. (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
Reviewers:
julienp, msw, sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove views::SingleSplitView as it's presently unused. BUG=none Committed: https://crrev.com/47b16f50429d4928aaed50de2ebb038184b753ac Cr-Commit-Position: refs/heads/master@{#405868}

Patch Set 1 #

Patch Set 2 : remove obsolete references #

Patch Set 3 : fix includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -958 lines) Patch
M chrome/browser/ui/views/frame/browser_view_layout.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D ui/views/controls/single_split_view.h View 1 chunk +0 lines, -148 lines 0 comments Download
D ui/views/controls/single_split_view.cc View 1 chunk +0 lines, -264 lines 0 comments Download
D ui/views/controls/single_split_view_listener.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/views/controls/single_split_view_unittest.cc View 1 chunk +0 lines, -251 lines 0 comments Download
M ui/views/examples/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D ui/views/examples/double_split_view_example.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/views/examples/double_split_view_example.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M ui/views/examples/examples.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/views/examples/examples_window.cc View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
D ui/views/examples/single_split_view_example.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ui/views/examples/single_split_view_example.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M ui/views/views.gyp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
Evan Stade
I believe Opera might still be using this but Chromium is not. Should it be ...
4 years, 5 months ago (2016-07-12 18:30:37 UTC) #2
sadrul
lgtm (we define new View types where needed, e.g. there are some types defined in ...
4 years, 5 months ago (2016-07-12 19:37:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144753002/20001
4 years, 5 months ago (2016-07-12 19:45:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/51564)
4 years, 5 months ago (2016-07-12 20:51:41 UTC) #8
julienp
On 2016/07/12 19:37:15, sadrul wrote: > If this code is used by some component in ...
4 years, 5 months ago (2016-07-13 08:43:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144753002/40001
4 years, 5 months ago (2016-07-13 16:52:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/217319)
4 years, 5 months ago (2016-07-13 17:03:58 UTC) #14
Evan Stade
+msw for (trivial) changes to c/b/u/v
4 years, 5 months ago (2016-07-15 19:29:45 UTC) #16
msw
lgtm
4 years, 5 months ago (2016-07-15 19:37:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144753002/40001
4 years, 5 months ago (2016-07-15 20:44:56 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-15 21:51:15 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 21:51:34 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 21:53:29 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47b16f50429d4928aaed50de2ebb038184b753ac
Cr-Commit-Position: refs/heads/master@{#405868}

Powered by Google App Engine
This is Rietveld 408576698