Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2144733011: Use SkCanvas transform instead of flipSkImageVertically (Closed)

Created:
4 years, 5 months ago by xidachen
Modified:
4 years, 5 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SkCanvas transform instead of flipSkImageVertically Currently in ImageBitmap, whenever we need to flip a SkImage, we call the function flipSkImageVertically, which read the pixels of the SkImage, swap the pixels and construct a new SkImage from the swapped pixels again. This process is un-necessary in the case where we already have a SkCanvas and are drawing to that canvas. In this case, we can just call the equivalent transformation on SkCanvas to achieve the same flipY effect. Committed: https://crrev.com/433fb76ec9ee583017b02903c958f0af5a022829 Cr-Commit-Position: refs/heads/master@{#406102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
xidachen
PTAL
4 years, 5 months ago (2016-07-15 15:06:13 UTC) #2
Justin Novosad
Excellent idea lgtm
4 years, 5 months ago (2016-07-18 15:06:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144733011/1
4 years, 5 months ago (2016-07-18 21:26:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 21:35:04 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 21:35:19 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:37:11 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/433fb76ec9ee583017b02903c958f0af5a022829
Cr-Commit-Position: refs/heads/master@{#406102}

Powered by Google App Engine
This is Rietveld 408576698