[SPv2] Move PaintPropertyTreeBuilder state for containing blocks into a struct.

[SPv2] Move PaintPropertyTreeBuilder state for containing blocks into a struct.

This makes it easier to see that copies of all relevant fields are correct,
and also makes it easier to add new state inherited on the containing block chain.

BUG=563667
Committed: https://crrev.com/3b0ebe0bfdbc9fc105b2c5b0af192e8b622a0477
Cr-Commit-Position: refs/heads/master@{#405566}

[jbroman, 2016-07-14 18:20:56]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 18:21:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-07-14 18:24:44]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 18:25:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-07-14 18:27:13]

jbroman@chromium.org changed reviewers:
+ pdr@chromium.org, trchen@chromium.org

[jbroman, 2016-07-14 18:27:14]

This makes my response to comments on the 3DRC/flattening CL simpler, and I
think is a useful refactor anyhow. Terse names were chosen because they are used
so much in this file, and I think this reads better (e.g. "clipForFixedPosition"
and "fixedPosition.clip" are both readable;
"containingBlockContextForFixedPosition.clip" is excessive).

This allows more containing-block-inherited state to be added without having to
add it to the places where that data is copied.

[pdr., 2016-07-14 18:50:31]

On 2016/07/14 at 18:27:14, jbroman wrote:
> This makes my response to comments on the 3DRC/flattening CL simpler, and I
think is a useful refactor anyhow. Terse names were chosen because they are used
so much in this file, and I think this reads better (e.g. "clipForFixedPosition"
and "fixedPosition.clip" are both readable;
"containingBlockContextForFixedPosition.clip" is excessive).
> 
> This allows more containing-block-inherited state to be added without having
to add it to the places where that data is copied.

LGTM

Please give trchen a chance to review this too

[trchen, 2016-07-14 20:49:42]

Makes sense to me. lgtm.

[commit-bot: I haz the power, 2016-07-14 20:49:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 20:49:46]

Dry run: This issue passed the CQ dry run.

[trchen, 2016-07-14 20:49:55]

The CQ bit was checked by trchen@chromium.org

[jbroman, 2016-07-14 20:50:14]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-07-14 20:50:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 20:57:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 20:59:52]

Description was changed from

==========
[SPv2] Move PaintPropertyTreeBuilder state for containing blocks into a struct.

This makes it easier to see that copies of all relevant fields are correct,
and also makes it easier to add new state inherited on the containing block
chain.

BUG=563667
==========

to

==========
[SPv2] Move PaintPropertyTreeBuilder state for containing blocks into a struct.

This makes it easier to see that copies of all relevant fields are correct,
and also makes it easier to add new state inherited on the containing block
chain.

BUG=563667

Committed: https://crrev.com/3b0ebe0bfdbc9fc105b2c5b0af192e8b622a0477
Cr-Commit-Position: refs/heads/master@{#405566}
==========

[commit-bot: I haz the power, 2016-07-14 20:59:53]

Patchset 2 (id:??) landed as
https://crrev.com/3b0ebe0bfdbc9fc105b2c5b0af192e8b622a0477
Cr-Commit-Position: refs/heads/master@{#405566}