Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3301)

Unified Diff: Source/core/rendering/style/RenderStyle.h

Issue 214473004: Rename RenderStyle::diff and RenderStyle::compare to better names (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: better names Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/style/RenderStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/style/RenderStyle.h
diff --git a/Source/core/rendering/style/RenderStyle.h b/Source/core/rendering/style/RenderStyle.h
index 3cbdf5073e1f503a45420bde7718bc1239b66552..14366d5e9710c8c37d657bba64814cefd29de74e 100644
--- a/Source/core/rendering/style/RenderStyle.h
+++ b/Source/core/rendering/style/RenderStyle.h
@@ -356,7 +356,11 @@ public:
static PassRefPtr<RenderStyle> createAnonymousStyleWithDisplay(const RenderStyle* parentStyle, EDisplay);
static PassRefPtr<RenderStyle> clone(const RenderStyle*);
- static StyleRecalcChange compare(const RenderStyle* oldStyle, const RenderStyle* newStyle);
+ // Computes how the style change should be propogated through the tree.
rune 2014/03/27 11:50:51 Minor nit: I think I would have said "down the tre
+ static StyleRecalcChange stylePropogationDiff(const RenderStyle* oldStyle, const RenderStyle* newStyle);
rune 2014/03/27 11:50:51 Propogation -> Propagation Same misspelling in th
+
+ // Computes how much visual invalidation the style change causes: layout, repaint or recomposite.
+ StyleDifference visualInvalidationDiff(const RenderStyle*, unsigned& changedContextSensitiveProperties) const;
enum IsAtShadowBoundary {
AtShadowBoundary,
@@ -1494,8 +1498,6 @@ public:
bool inheritedNotEqual(const RenderStyle*) const;
bool inheritedDataShared(const RenderStyle*) const;
- StyleDifference diff(const RenderStyle*, unsigned& changedContextSensitiveProperties) const;
-
bool isDisplayReplacedType() const { return isDisplayReplacedType(display()); }
bool isDisplayInlineType() const { return isDisplayInlineType(display()); }
bool isOriginalDisplayInlineType() const { return isDisplayInlineType(originalDisplay()); }
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/style/RenderStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698