Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 214473002: Update expectations for WebSocket layout tests (Closed)

Created:
6 years, 9 months ago by Adam Rice
Modified:
6 years, 9 months ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update expectations for WebSocket layout tests interleaved-fragments.html, invalid-continuation.html, zero-length-text.html, connect-src-websocket-allowed.html and handshake-error.html now pass. All other WebSocket tests which were set to "Skip" have been changed to "Failure", except for multiple-connections.html, which times out. Tests of functionality which is not implemented in the new implementation remain skipped. These are FIXME-handshake-fail-by-null-subprotocol-selection-whitelist.html, handshake-fail-by-no-cr.html and deflate-frame-* BUG=339373 TEST=layout tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170258

Patch Set 1 #

Patch Set 2 : Add handshake-fail-by-no-cr.html to the skipped test set. #

Patch Set 3 : Fix bug number of useragent-in-openinghandshake.html and comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Adam Rice
6 years, 9 months ago (2014-03-27 10:20:21 UTC) #1
yhirano
lgtm. Please update the description.
6 years, 9 months ago (2014-03-27 11:08:03 UTC) #2
Adam Rice
The CQ bit was checked by ricea@chromium.org
6 years, 9 months ago (2014-03-27 17:03:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/214473002/40001
6 years, 9 months ago (2014-03-27 17:03:24 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 18:06:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 18:06:54 UTC) #6
Adam Rice
The CQ bit was checked by ricea@chromium.org
6 years, 9 months ago (2014-03-28 02:38:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/214473002/40001
6 years, 9 months ago (2014-03-28 02:39:05 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 03:41:57 UTC) #9
Message was sent while issue was closed.
Change committed as 170258

Powered by Google App Engine
This is Rietveld 408576698