Reland of Add CheckOCSPDateValid() to net/cert/internal

net/der/encode_values_unittest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/time/time.h"
+#include "net/der/encode_values.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+namespace der {
+namespace test {
+
+TEST(EncodeValuesTest, EncodeTimeAsGeneralizedTime) {
+  // Fri, 24 Jun 2016 17:04:54 GMT
+  base::Time time =
+      base::Time::UnixEpoch() + base::TimeDelta::FromSeconds(1466787894);
+  GeneralizedTime generalized_time;
+  ASSERT_TRUE(EncodeTimeAsGeneralizedTime(time, &generalized_time));
+  EXPECT_EQ(2016, generalized_time.year);
+  EXPECT_EQ(6, generalized_time.month);
+  EXPECT_EQ(24, generalized_time.day);
+  EXPECT_EQ(17, generalized_time.hours);
+  EXPECT_EQ(4, generalized_time.minutes);
+  EXPECT_EQ(54, generalized_time.seconds);
+}
+
+TEST(EncodeValuesTest, EncodeTimeFromBeforeWindows) {

[Ryan Sleevi, 2016/07/13 01:17:18]

More documentation needed.

// Although the ASN.1 GeneralizedTime can represent dates from
// the years 0000 to 9999, and although base::Time can represent
// dates before the Windows epoch, if the underlying system can't
// handle dates within the range, it should not be possible to
// encode as a GeneralizedTime.

That's one sort of half-focused approach to the documentation, but certainly,
these tests are now a bit more magical.

For example, I have no idea why you chose FromUTCExploded vs UTCExplode - if
that was convenience or meaningful. Documentation helps :)

[dadrian, 2016/07/13 02:38:34]

Done.

+  // Thu, 1 Jan 1570 00:00:00 GMT
+  base::Time::Exploded exploded;
+  exploded.year = 1570;
+  exploded.month = 1;
+  exploded.day_of_week = 5;
+  exploded.hour = 0;
+  exploded.minute = 0;
+  exploded.second = 0;
+  exploded.millisecond = 0;
+  base::Time time;
+  if (base::Time::FromUTCExploded(exploded, &time)) {

[Ryan Sleevi, 2016/07/13 01:17:18]

Short-circuit and return early

if (!base::Time::FromUTCExploded(...))
  return

GeneralizedTime generalized_time

[dadrian, 2016/07/13 02:38:34]

Done.

+    GeneralizedTime generalized_time;
+    ASSERT_TRUE(EncodeTimeAsGeneralizedTime(time, &generalized_time));
+    EXPECT_EQ(1570, generalized_time.year);
+    EXPECT_EQ(1, generalized_time.month);
+    EXPECT_EQ(1, generalized_time.day);
+    EXPECT_EQ(0, generalized_time.hours);
+    EXPECT_EQ(0, generalized_time.minutes);
+    EXPECT_EQ(0, generalized_time.seconds);
+  }
+}
+
+TEST(EncodeValuesTest, EncodeTimeAfterTimeTMax) {

[Ryan Sleevi, 2016/07/13 01:17:18]

same comments re docs & short-circuit

[dadrian, 2016/07/13 02:38:34]

Done.

+  // Sat, 1 Jan 2039 00:00:00 GMT
+  base::Time::Exploded exploded;
+  exploded.year = 2039;
+  exploded.month = 1;
+  exploded.day_of_week = 7;
+  exploded.hour = 0;
+  exploded.minute = 0;
+  exploded.second = 0;
+  exploded.millisecond = 0;
+  base::Time time;
+  if (base::Time::FromUTCExploded(exploded, &time)) {
+    GeneralizedTime generalized_time;
+    ASSERT_TRUE(EncodeTimeAsGeneralizedTime(time, &generalized_time));
+    EXPECT_EQ(2039, generalized_time.year);
+    EXPECT_EQ(1, generalized_time.month);
+    EXPECT_EQ(1, generalized_time.day);
+    EXPECT_EQ(0, generalized_time.hours);
+    EXPECT_EQ(0, generalized_time.minutes);
+    EXPECT_EQ(0, generalized_time.seconds);
+  }
+}
+
+}  // namespace test
+
+}  // namespace der
+
+}  // namespace net