Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chromecast/renderer/cast_content_renderer_client.cc

Issue 2144683002: [Chromecast] Fix window size/page scale issues on ATV (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/renderer/cast_content_renderer_client.cc
diff --git a/chromecast/renderer/cast_content_renderer_client.cc b/chromecast/renderer/cast_content_renderer_client.cc
index 1544f84f40997dc5810f5a36f458e7d352c73a4c..02da545aba649f24f76eeecbfa7ce35164f254e3 100644
--- a/chromecast/renderer/cast_content_renderer_client.cc
+++ b/chromecast/renderer/cast_content_renderer_client.cc
@@ -96,17 +96,11 @@ void CastContentRendererClient::RenderViewCreated(
blink::WebFrameWidget* web_frame_widget = render_view->GetWebFrameWidget();
web_frame_widget->setBaseBackgroundColor(kColorBlack);
- // The following settings express consistent behaviors across Cast
- // embedders, though Android has enabled by default for mobile browsers.
- webview->settings()->setShrinksViewportContentToFit(false);
+ // Settings for ATV (Android defaults are not what we want):
webview->settings()->setMediaControlsOverlayPlayButtonEnabled(false);
- // Scale 1 ensures window.innerHeight/Width match application resolution.
- // PageScaleOverride is the 'user agent' value which overrides page
- // settings (from meta viewport tag) - thus preventing inconsistency
- // between Android and non-Android cast_shell.
- webview->setDefaultPageScaleLimits(1.f, 1.f);
- webview->setInitialPageScaleOverride(1.f);
+ // Necessary to get correct initial page scale across all devices:
+ webview->settings()->setShrinksViewportContentToFit(true);
alokp 2016/07/12 17:03:38 nit: I would just delete this line if the default
halliwell 2016/07/12 17:11:43 Done.
// Disable application cache as Chromecast doesn't support off-line
// application running.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698