[Chromecast] Fix window size/page scale issues on ATV

[Chromecast] Fix window size/page scale issues on ATV

As far as I can tell, setShrinksViewportContentToFit = false was
added first to work around some resolution bug.  This broke automatic
page scale factor calculation later on, which we fixed in turn by
forcing page scale factor = 1.  And this then broke with the recent
fixes to device pixel ratio.

It seems that unwinding this whole sequence of workarounds gives
correct behaviour.

BUG=internal b/29215234
TEST=inspected resolution properties + Cast YT on ATV + variety
     of Chromecast hardware

Committed: https://crrev.com/7c46711091a782aa5d674e4d682936fa32c93d15
Cr-Commit-Position: refs/heads/master@{#404831}

[halliwell, 2016-07-12 16:57:41]

Description was changed from

==========
[Chromecast] Fix window size/page scale issues on ATV

As far as I can tell, setShrinksViewportContentToFit = false was
added first to work around some resolution bug.  This broke automatic
page scale factor calculation later on, which we fixed in turn by
forcing page scale factor = 1.  And this then broke with the recent
fixes to device pixel ratio.

It seems that unwinding this whole sequence of workarounds gives
correct behaviour.

BUG=internal b/29215234
TEST=inspected resolution properties + Cast YT on ATV + variety
     of Chromecast hardware
==========

to

==========
[Chromecast] Fix window size/page scale issues on ATV

As far as I can tell, setShrinksViewportContentToFit = false was
added first to work around some resolution bug.  This broke automatic
page scale factor calculation later on, which we fixed in turn by
forcing page scale factor = 1.  And this then broke with the recent
fixes to device pixel ratio.

It seems that unwinding this whole sequence of workarounds gives
correct behaviour.

BUG=internal b/29215234
TEST=inspected resolution properties + Cast YT on ATV + variety
     of Chromecast hardware
==========

[halliwell, 2016-07-12 16:57:42]

halliwell@chromium.org changed reviewers:
+ alokp@chromium.org, sanfin@chromium.org

[alokp, 2016-07-12 17:03:38]

nice! 
lgtm

https://codereview.chromium.org/2144683002/diff/1/chromecast/renderer/cast_co...
File chromecast/renderer/cast_content_renderer_client.cc (right):

https://codereview.chromium.org/2144683002/diff/1/chromecast/renderer/cast_co...
chromecast/renderer/cast_content_renderer_client.cc:103:
webview->settings()->setShrinksViewportContentToFit(true);
nit: I would just delete this line if the default value is true.

[Simeon, 2016-07-12 17:05:52]

On 2016/07/12 16:57:46, halliwell wrote:

lgtm

[halliwell, 2016-07-12 17:11:43]

https://codereview.chromium.org/2144683002/diff/1/chromecast/renderer/cast_co...
File chromecast/renderer/cast_content_renderer_client.cc (right):

https://codereview.chromium.org/2144683002/diff/1/chromecast/renderer/cast_co...
chromecast/renderer/cast_content_renderer_client.cc:103:
webview->settings()->setShrinksViewportContentToFit(true);
On 2016/07/12 17:03:38, alokp wrote:
> nit: I would just delete this line if the default value is true.

Done.

[halliwell, 2016-07-12 17:11:48]

The CQ bit was checked by halliwell@chromium.org

[halliwell, 2016-07-12 17:11:50]

The patchset sent to the CQ was uploaded after l-g-t-m from sanfin@chromium.org,
alokp@chromium.org
Link to the patchset: https://codereview.chromium.org/2144683002/#ps20001
(title: "Defaults are fine for linux")

[commit-bot: I haz the power, 2016-07-12 17:12:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 20:38:12]

Description was changed from

==========
[Chromecast] Fix window size/page scale issues on ATV

As far as I can tell, setShrinksViewportContentToFit = false was
added first to work around some resolution bug.  This broke automatic
page scale factor calculation later on, which we fixed in turn by
forcing page scale factor = 1.  And this then broke with the recent
fixes to device pixel ratio.

It seems that unwinding this whole sequence of workarounds gives
correct behaviour.

BUG=internal b/29215234
TEST=inspected resolution properties + Cast YT on ATV + variety
     of Chromecast hardware
==========

to

==========
[Chromecast] Fix window size/page scale issues on ATV

As far as I can tell, setShrinksViewportContentToFit = false was
added first to work around some resolution bug.  This broke automatic
page scale factor calculation later on, which we fixed in turn by
forcing page scale factor = 1.  And this then broke with the recent
fixes to device pixel ratio.

It seems that unwinding this whole sequence of workarounds gives
correct behaviour.

BUG=internal b/29215234
TEST=inspected resolution properties + Cast YT on ATV + variety
     of Chromecast hardware
==========

[commit-bot: I haz the power, 2016-07-12 20:38:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-12 20:38:43]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-12 20:40:59]

Description was changed from

==========
[Chromecast] Fix window size/page scale issues on ATV

As far as I can tell, setShrinksViewportContentToFit = false was
added first to work around some resolution bug.  This broke automatic
page scale factor calculation later on, which we fixed in turn by
forcing page scale factor = 1.  And this then broke with the recent
fixes to device pixel ratio.

It seems that unwinding this whole sequence of workarounds gives
correct behaviour.

BUG=internal b/29215234
TEST=inspected resolution properties + Cast YT on ATV + variety
     of Chromecast hardware
==========

to

==========
[Chromecast] Fix window size/page scale issues on ATV

As far as I can tell, setShrinksViewportContentToFit = false was
added first to work around some resolution bug.  This broke automatic
page scale factor calculation later on, which we fixed in turn by
forcing page scale factor = 1.  And this then broke with the recent
fixes to device pixel ratio.

It seems that unwinding this whole sequence of workarounds gives
correct behaviour.

BUG=internal b/29215234
TEST=inspected resolution properties + Cast YT on ATV + variety
     of Chromecast hardware

Committed: https://crrev.com/7c46711091a782aa5d674e4d682936fa32c93d15
Cr-Commit-Position: refs/heads/master@{#404831}
==========

[commit-bot: I haz the power, 2016-07-12 20:41:00]

Patchset 2 (id:??) landed as
https://crrev.com/7c46711091a782aa5d674e4d682936fa32c93d15
Cr-Commit-Position: refs/heads/master@{#404831}