Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 2144653004: DevTools: Headless inspection targets can screencast by default. (Closed)

Created:
4 years, 5 months ago by paulirish
Modified:
4 years, 5 months ago
CC:
chromium-reviews, devtools-reviews_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Headless inspection targets can screencast by default. Screencast is available for our headless clients and turned on if remoteFrontend queryparam is set. This CL also begins using the devtool frontend from the cloud for 2 reasons: 1. We need the frontend to version match our headless target 2. The screencast module isn't in the bundled devtools, and only in the cloud. BUG=627541 Committed: https://crrev.com/df6f3288d2a26aa994b11fbfff2360525c43f98d Cr-Commit-Position: refs/heads/master@{#407035}

Patch Set 1 #

Total comments: 10

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M headless/lib/resources/devtools_discovery_page.html View 1 1 chunk +29 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
paulirish
4 years, 5 months ago (2016-07-12 18:14:22 UTC) #2
paulirish
@pfeldman & @alexclarke, ptal! This allows screencasting by default for the headless discovery page. It ...
4 years, 5 months ago (2016-07-18 21:09:59 UTC) #3
alex clarke (OOO till 29th)
lgtm
4 years, 5 months ago (2016-07-19 14:16:23 UTC) #4
paulirish
Just to explain to pfeldman the portion that could use a refactor. :) https://codereview.chromium.org/2144653004/diff/1/headless/lib/resources/devtools_discovery_page.html File ...
4 years, 5 months ago (2016-07-20 17:37:06 UTC) #5
pfeldman
https://codereview.chromium.org/2144653004/diff/1/headless/lib/resources/devtools_discovery_page.html File headless/lib/resources/devtools_discovery_page.html (right): https://codereview.chromium.org/2144653004/diff/1/headless/lib/resources/devtools_discovery_page.html#newcode11 headless/lib/resources/devtools_discovery_page.html:11: const listPromise = fetchjson("/json/list?t=" + Date.now()); /json/list does not ...
4 years, 5 months ago (2016-07-20 18:13:14 UTC) #6
paulirish
thanks. ptal https://codereview.chromium.org/2144653004/diff/1/headless/lib/resources/devtools_discovery_page.html File headless/lib/resources/devtools_discovery_page.html (right): https://codereview.chromium.org/2144653004/diff/1/headless/lib/resources/devtools_discovery_page.html#newcode11 headless/lib/resources/devtools_discovery_page.html:11: const listPromise = fetchjson("/json/list?t=" + Date.now()); On ...
4 years, 5 months ago (2016-07-20 19:38:47 UTC) #7
pfeldman
lgtm
4 years, 5 months ago (2016-07-21 22:03:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144653004/20001
4 years, 5 months ago (2016-07-21 23:54:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 03:39:48 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:42:18 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df6f3288d2a26aa994b11fbfff2360525c43f98d
Cr-Commit-Position: refs/heads/master@{#407035}

Powered by Google App Engine
This is Rietveld 408576698