[Autofill] Log whether queried credit card form context is secure

components/autofill/core/browser/autofill_metrics_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <vector>
@@ skipping 137 matching lines @@
   }
 
   // Removes all existing credit cards and creates 0 or 1 local profiles and
   // 0 or 1 server profile according to the paramters.
   void RecreateCreditCards(bool include_local_credit_card,
                            bool include_masked_server_credit_card,
                            bool include_full_server_credit_card) {
     local_credit_cards_.clear();
     server_credit_cards_.clear();
     if (include_local_credit_card) {
-      CreditCard* credit_card = new CreditCard;
+      CreditCard* credit_card =
+          new CreditCard(base::ASCIIToUTF16("4111111111111111"), 12, 24);
       credit_card->set_guid("10000000-0000-0000-0000-000000000001");
       local_credit_cards_.push_back(credit_card);
     }
     if (include_masked_server_credit_card) {
       CreditCard* credit_card = new CreditCard(
           CreditCard::MASKED_SERVER_CARD, "server_id");
       credit_card->set_guid("10000000-0000-0000-0000-000000000002");
       credit_card->SetTypeForMaskedCard(kDiscoverCard);
       server_credit_cards_.push_back(credit_card);
     }
@@ skipping 1636 matching lines @@
                    "Autofill_PolledCreditCardSuggestions"));
 
   // Simulate a query back to the initial field. There should be a third poll
   // logged.
   autofill_manager_->OnQueryFormFieldAutofill(0, form, form.fields[0],
                                               gfx::RectF());
   EXPECT_EQ(3, user_action_tester.GetActionCount(
                    "Autofill_PolledCreditCardSuggestions"));
 }
 
+// Tests that the Autofill.QueriedCreditCardFormIsSecure histogram is logged
+// properly.
+TEST_F(AutofillMetricsTest, QueriedCreditCardFormIsSecure) {
+  personal_data_->RecreateCreditCards(
+      true /* include_local_credit_card */,
+      false /* include_masked_server_credit_card */,
+      false /* include_full_server_credit_card */);
+
+  // Set up the form data.
+  FormData form;
+  form.name = ASCIIToUTF16("TestForm");
+  form.origin = GURL("http://example.com/form.html");
+  form.action = GURL("http://example.com/submit.html");
+
+  FormFieldData field;
+  std::vector<ServerFieldType> field_types;
+  test::CreateTestFormField("Month", "card_month", "", "text", &field);
+  form.fields.push_back(field);
+  field_types.push_back(CREDIT_CARD_EXP_MONTH);
+  test::CreateTestFormField("Year", "card_year", "", "text", &field);
+  form.fields.push_back(field);
+  field_types.push_back(CREDIT_CARD_EXP_2_DIGIT_YEAR);
+  test::CreateTestFormField("Credit card", "card", "", "text", &field);
+  form.fields.push_back(field);
+  field_types.push_back(CREDIT_CARD_NUMBER);
+
+  // Simulate having seen this form on page load.
+  // |form_structure| will be owned by |autofill_manager_|.

[Ilya Sherman, 2016/07/12 21:33:04]

nit: Please omit the ownership comment, since it doesn't seem to apply here.

[Mathieu, 2016/07/13 01:32:57]

Done.

+  autofill_manager_->AddSeenForm(form, field_types, field_types);
+
+  {
+    // Simulate an Autofill query on a credit card field.
+    base::HistogramTester histogram_tester;
+    autofill_client_.set_is_context_secure(true);

[Ilya Sherman, 2016/07/12 21:33:04]

nit: I'd swap the order of the above two lines (and ditto below), so that you're
testing the narrowest possible window for when the metric is set.

[Mathieu, 2016/07/13 01:32:57]

Done.

+    autofill_manager_->OnQueryFormFieldAutofill(0, form, form.fields[1],
+                                                gfx::RectF());
+    histogram_tester.ExpectUniqueSample(
+        "Autofill.QueriedCreditCardFormIsSecure", true, 1);
+  }
+
+  {
+    // Simulate an Autofill query on a credit card field.
+    base::HistogramTester histogram_tester;
+    autofill_client_.set_is_context_secure(false);
+    autofill_manager_->OnQueryFormFieldAutofill(0, form, form.fields[1],
+                                                gfx::RectF());
+    histogram_tester.ExpectUniqueSample(
+        "Autofill.QueriedCreditCardFormIsSecure", false, 1);
+  }
+}
+
 // Tests that the Autofill_PolledProfileSuggestions user action is only logged
 // once if the field is queried repeatedly.
 TEST_F(AutofillMetricsTest, PolledProfileSuggestions_DebounceLogs) {
   personal_data_->RecreateProfiles(true /* include_local_profile */,
                                    false /* include_server_profile */);
 
   // Set up the form data.
   FormData form;
   form.name = ASCIIToUTF16("TestForm");
   form.origin = GURL("http://example.com/form.html");
@@ skipping 2192 matching lines @@
   EXPECT_THAT(
       histogram_tester.GetAllSamples("Autofill.ServerResponseHasDataForForm"),
       ElementsAre(Bucket(true, 2)));
 
   // No RAPPOR metrics are logged in the case there is at least some server data
   // available for all forms.
   EXPECT_EQ(0, rappor_service_.GetReportsCount());
 }
 
 }  // namespace autofill