Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2144643005: PPC/s390: [Interpreter] Collect type feedback for calls in the bytecode handler (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [Interpreter] Collect type feedback for calls in the bytecode handler Port fd420203ecb5abe427bda14aa896d90919d998fb Original commit message: Collect type feedback in the call bytecode handler. The current implementation only collects feedback for JS function objects. The other objects and Array functions do not collect any feedback. They will be marked Megamorphic. R=mythria@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280, v8:4780 LOG=N Committed: https://crrev.com/32d1314e6384f70bfaff437dd900fb56c011e3a0 Cr-Commit-Position: refs/heads/master@{#37724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M src/s390/builtins-s390.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-07-13 15:56:27 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-07-13 16:26:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144643005/1
4 years, 5 months ago (2016-07-13 16:27:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 16:55:36 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 16:55:38 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:58:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32d1314e6384f70bfaff437dd900fb56c011e3a0
Cr-Commit-Position: refs/heads/master@{#37724}

Powered by Google App Engine
This is Rietveld 408576698