Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2144633002: sandwich: Uses original WPR archive for prefetch benchmark runs (Closed)

Created:
4 years, 5 months ago by gabadie
Modified:
4 years, 5 months ago
Reviewers:
pasko
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandwich: Uses original WPR archive for prefetch benchmark runs Before, Sandwich was using the patched WPR archive with headers ensure the resource get cached. But that could lead to non realistic page load time in theory if multiple requests are issued on uncachable resources. This CL fixes this issue by using the original WPR archive when running the benchmarks for NoState-Prefetch. BUG=582080 Committed: https://crrev.com/4f7630de82bf4b4bd0c6b13a6196c9ae57c61052 Cr-Commit-Position: refs/heads/master@{#405081}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/android/loading/sandwich_prefetch.py View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 14 (5 generated)
gabadie
4 years, 5 months ago (2016-07-12 15:30:26 UTC) #2
pasko
good catch! and a great commit message! lgtm, regardless of the suggestion below https://codereview.chromium.org/2144633002/diff/1/tools/android/loading/sandwich_prefetch.py File ...
4 years, 5 months ago (2016-07-12 15:37:43 UTC) #3
gabadie
Thanks! Landing. https://codereview.chromium.org/2144633002/diff/1/tools/android/loading/sandwich_prefetch.py File tools/android/loading/sandwich_prefetch.py (right): https://codereview.chromium.org/2144633002/diff/1/tools/android/loading/sandwich_prefetch.py#newcode649 tools/android/loading/sandwich_prefetch.py:649: dependencies=[BuildBenchmarkCacheArchive]) On 2016/07/12 15:37:43, pasko wrote: > ...
4 years, 5 months ago (2016-07-12 15:47:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144633002/1
4 years, 5 months ago (2016-07-12 15:48:53 UTC) #6
pasko
https://codereview.chromium.org/2144633002/diff/1/tools/android/loading/sandwich_prefetch.py File tools/android/loading/sandwich_prefetch.py (right): https://codereview.chromium.org/2144633002/diff/1/tools/android/loading/sandwich_prefetch.py#newcode649 tools/android/loading/sandwich_prefetch.py:649: dependencies=[BuildBenchmarkCacheArchive]) On 2016/07/12 15:47:42, gabadie wrote: > On 2016/07/12 ...
4 years, 5 months ago (2016-07-12 15:51:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261169)
4 years, 5 months ago (2016-07-12 18:48:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144633002/1
4 years, 5 months ago (2016-07-13 07:56:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 08:34:10 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:35:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f7630de82bf4b4bd0c6b13a6196c9ae57c61052
Cr-Commit-Position: refs/heads/master@{#405081}

Powered by Google App Engine
This is Rietveld 408576698