sandwich: Uses original WPR archive for prefetch benchmark runs

sandwich: Uses original WPR archive for prefetch benchmark runs

Before, Sandwich was using the patched WPR archive with headers
ensure the resource get cached. But that could lead to non realistic
page load time in theory if multiple requests are issued on uncachable
resources.

This CL fixes this issue by using the original WPR archive when running
the benchmarks for NoState-Prefetch.

BUG=582080
Committed: https://crrev.com/4f7630de82bf4b4bd0c6b13a6196c9ae57c61052
Cr-Commit-Position: refs/heads/master@{#405081}

[gabadie, 2016-07-12 15:30:26]

gabadie@chromium.org changed reviewers:
+ pasko@chromium.org

[pasko, 2016-07-12 15:37:43]

good catch! and a great commit message!

lgtm, regardless of the suggestion below

https://codereview.chromium.org/2144633002/diff/1/tools/android/loading/sandw...
File tools/android/loading/sandwich_prefetch.py (right):

https://codereview.chromium.org/2144633002/diff/1/tools/android/loading/sandw...
tools/android/loading/sandwich_prefetch.py:649:
dependencies=[BuildBenchmarkCacheArchive])
should we also add original_wpr_task to dependencies?

[gabadie, 2016-07-12 15:47:42]

Thanks! Landing.

https://codereview.chromium.org/2144633002/diff/1/tools/android/loading/sandw...
File tools/android/loading/sandwich_prefetch.py (right):

https://codereview.chromium.org/2144633002/diff/1/tools/android/loading/sandw...
tools/android/loading/sandwich_prefetch.py:649:
dependencies=[BuildBenchmarkCacheArchive])
On 2016/07/12 15:37:43, pasko wrote:
> should we also add original_wpr_task to dependencies?

We don't need to, because it is already an indirect dependency. More over adding
the explicit dependency here might make graph manipulation from the command line
(-e and -f) more difficult to handle for human because need to freeze more stuf
if you want to rerun this particular task.

[gabadie, 2016-07-12 15:47:46]

The CQ bit was checked by gabadie@chromium.org

[commit-bot: I haz the power, 2016-07-12 15:48:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pasko, 2016-07-12 15:51:56]

https://codereview.chromium.org/2144633002/diff/1/tools/android/loading/sandw...
File tools/android/loading/sandwich_prefetch.py (right):

https://codereview.chromium.org/2144633002/diff/1/tools/android/loading/sandw...
tools/android/loading/sandwich_prefetch.py:649:
dependencies=[BuildBenchmarkCacheArchive])
On 2016/07/12 15:47:42, gabadie wrote:
> On 2016/07/12 15:37:43, pasko wrote:
> > should we also add original_wpr_task to dependencies?
> 
> We don't need to, because it is already an indirect dependency. More over
adding
> the explicit dependency here might make graph manipulation from the command
line
> (-e and -f) more difficult to handle for human because need to freeze more
stuf
> if you want to rerun this particular task.

yeah, the question whether to make all dependencies explicit is rather
philosophical. I agree with your assessment, and I also did not know that it
would cause more 'freezing complexity'. SG.

[commit-bot: I haz the power, 2016-07-12 18:48:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:48:44]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gabadie, 2016-07-13 07:56:14]

The CQ bit was checked by gabadie@chromium.org

[commit-bot: I haz the power, 2016-07-13 07:56:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 08:34:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 08:35:17]

Description was changed from

==========
sandwich: Uses original WPR archive for prefetch benchmark runs

Before, Sandwich was using the patched WPR archive with headers
ensure the resource get cached. But that could lead to non realistic
page load time in theory if multiple requests are issued on uncachable
resources.

This CL fixes this issue by using the original WPR archive when running
the benchmarks for NoState-Prefetch.

BUG=582080
==========

to

==========
sandwich: Uses original WPR archive for prefetch benchmark runs

Before, Sandwich was using the patched WPR archive with headers
ensure the resource get cached. But that could lead to non realistic
page load time in theory if multiple requests are issued on uncachable
resources.

This CL fixes this issue by using the original WPR archive when running
the benchmarks for NoState-Prefetch.

BUG=582080

Committed: https://crrev.com/4f7630de82bf4b4bd0c6b13a6196c9ae57c61052
Cr-Commit-Position: refs/heads/master@{#405081}
==========

[commit-bot: I haz the power, 2016-07-13 08:35:19]

Patchset 1 (id:??) landed as
https://crrev.com/4f7630de82bf4b4bd0c6b13a6196c9ae57c61052
Cr-Commit-Position: refs/heads/master@{#405081}