Separate audio player tests from special file test of Files.app

Separate audio player tests from special file test of Files.app

I have a plan to add more audio player tests. Before that, make audio player tests
separated for readability.

BUG=none
TEST=browser_test passes
R=hirono@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260069

[yoshiki, 2014-03-27 08:31:50]

@hirono, PTAL. Thanks.

[hirono, 2014-03-27 08:47:00]

On 2014/03/27 08:31:50, yoshiki wrote:
> @hirono, PTAL. Thanks.

open_audio_files.js is not added?

[yoshiki, 2014-03-27 08:49:43]

Added.

[hirono, 2014-03-27 08:54:20]

lgtm with a nit! Thanks!

https://codereview.chromium.org/214463002/diff/20001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/file_manager_browsertest/manifest.json
(right):

https://codereview.chromium.org/214463002/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/file_manager_browsertest/manifest.json:22:
"open_audio_files.js",
Please sort files in the alphabet order: open_audio_files -> open_special_types

[yoshiki, 2014-03-27 09:38:14]

thanks

https://codereview.chromium.org/214463002/diff/20001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/file_manager_browsertest/manifest.json
(right):

https://codereview.chromium.org/214463002/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/file_manager_browsertest/manifest.json:22:
"open_audio_files.js",
On 2014/03/27 08:54:20, hirono wrote:
> Please sort files in the alphabet order: open_audio_files ->
open_special_types

Done.

[yoshiki, 2014-03-27 09:38:17]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-03-27 09:38:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/214463002/40001

[commit-bot: I haz the power, 2014-03-27 16:05:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 16:05:26]

Failed to apply patch for
chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js
  Hunk #1 FAILED at 58.
  Hunk #2 succeeded at 211 (offset 43 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js.rej

Patch:      
chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js
Index:
chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js
diff --git
a/chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js
b/chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js
index
969569c66a88627c1da5d455e1a9969a0ee73cd7..1087950b49f21ce16fee36b482fff843fa1504c7
100644
---
a/chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js
+++
b/chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js
@@ -58,46 +58,6 @@ function galleryOpen(path) {
 }
 
 /**
- * Tests if the audio player shows up for the selected image and that the audio
- * is loaded successfully.
- *
- * @param {string} path Directory path to be tested.
- */
-function audioOpen(path) {
-  var appId;
-  var audioAppId;
-  StepsRunner.run([
-    function() {
-      setupAndWaitUntilReady(null, path, this.next);
-    },
-    // Select the song.
-    function(inAppId) {
-      appId = inAppId;
-      callRemoteTestUtil(
-          'openFile', appId, ['Beautiful Song.ogg'], this.next);
-    },
-    // Wait for the audio player.
-    function(result) {
-      chrome.test.assertTrue(result);
-      waitForWindow('audio_player.html').then(this.next);
-    },
-    // Wait for the audio tag and verify the source.
-    function(inAppId) {
-      audioAppId = inAppId;
-      waitForElement(audioAppId, 'audio-player[playing]').then(this.next);
-    },
-    // Get the title tag.
-    function(element) {
-      chrome.test.assertEq(
-          'filesystem:chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/' +
-              'external' + path + '/Beautiful%20Song.ogg',
-          element.attributes.currenttrackurl);
-      checkIfNoErrorsOccured(this.next);
-    }
-  ]);
-}
-
-/**
  * Tests if we can open and unmount a zip file.
  * @param {string} path Directory path to be tested.
  */
@@ -168,18 +128,10 @@ testcase.galleryOpenDownloads = function() {
   galleryOpen(RootPath.DOWNLOADS);
 };
 
-testcase.audioOpenDownloads = function() {
-  audioOpen(RootPath.DOWNLOADS);
-};
-
 testcase.galleryOpenDrive = function() {
   galleryOpen(RootPath.DRIVE);
 };
 
-testcase.audioOpenDrive = function() {
-  audioOpen(RootPath.DRIVE);
-};
-
 testcase.zipOpenDownloads = function() {
   zipOpen(RootPath.DOWNLOADS);
 };

[yoshiki, 2014-03-27 16:40:32]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-03-27 16:41:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/214463002/60001

[commit-bot: I haz the power, 2014-03-27 16:50:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 16:50:02]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[yoshiki, 2014-03-28 03:49:50]

Committed patchset #4 manually as r260069 (presubmit successful).