[sensors] Introduce Generic Sensor API interfaces

device/generic_sensor/platform_sensor_provider.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef DEVICE_SENSORS_PLATFORM_SENSOR_PROVIDER_H_
+#define DEVICE_SENSORS_PLATFORM_SENSOR_PROVIDER_H_
+
+#include "base/macros.h"
+
+#include "base/threading/non_thread_safe.h"
+#include "device/generic_sensor/platform_sensor.h"
+
+namespace device {
+
+// Base class that defines factory methods for PlatformSensor creation.
+class PlatformSensorProvider : public base::NonThreadSafe {
+ public:
+  static PlatformSensorProvider* Create(uint64_t shared_buffer_size);
+
+  // Creates new instance of PlatformSensor.
+  scoped_refptr<PlatformSensor> CreateSensor(mojom::SensorType type,
+                                             uint64_t size,
+                                             uint64_t offset);
+
+  // Gets previously created instance of PlatformSensor by sensor type |type|.
+  scoped_refptr<PlatformSensor> GetSensor(mojom::SensorType type);
+
+  // Shared buffer getters.
+  mojo::ScopedSharedBufferHandle GetClonedSharedBufferHandle();

[Reilly Grant (use Gerrit), 2016/08/11 20:59:37]

CloneSharedBufferHandle() would be a shorter/clearer name.

[Mikhail, 2016/08/12 10:21:48]

Done.

+
+ protected:
+  explicit PlatformSensorProvider(uint64_t shared_buffer_size);
+  virtual ~PlatformSensorProvider();
+
+  // Method that must be implemented by platform specific classes.
+  virtual scoped_refptr<PlatformSensor> CreateSensor(
+      mojom::SensorType type,
+      mojo::ScopedSharedBufferMapping mapping,
+      uint64_t buffer_size) = 0;

[Reilly Grant (use Gerrit), 2016/08/11 20:59:37]

This overload is definitely confusing. Please name it CreateSensorInternal().

[Mikhail, 2016/08/12 10:21:48]

Done.

+
+ private:
+  bool CreateSharedBufferIfNeeded();
+
+  friend class PlatformSensor;  // To call RemoveSensor();

[Reilly Grant (use Gerrit), 2016/08/11 20:59:37]

Move this line to the top of the private: section.

[Mikhail, 2016/08/12 10:21:48]

Done.

+  void RemoveSensor(mojom::SensorType type);
+
+ private:
+  using SensorMap = std::map<mojom::SensorType, PlatformSensor*>;

[Reilly Grant (use Gerrit), 2016/08/11 20:59:37]

This typedef is used only once here. Don't worry about the line below being
long.

[Mikhail, 2016/08/12 10:21:48]

Done.

+  SensorMap sensor_map_;
+  mojo::ScopedSharedBufferHandle shared_buffer_handle_;
+  uint64_t shared_buffer_size_;
+  DISALLOW_COPY_AND_ASSIGN(PlatformSensorProvider);
+};
+
+}  // namespace device
+
+#endif  // DEVICE_SENSORS_PLATFORM_SENSOR_PROVIDER_H_