Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 2144613002: [Turbofan] Register-register swap for x64 can use movapd instruction. (Closed)

Created:
4 years, 5 months ago by bbudge
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Register-register swap for x64 can use movapd instruction. LOG=N BUG=v8:4124 Committed: https://crrev.com/0ddd158b7418c7819b6eb239a2d64181d6412aa1 Cr-Commit-Position: refs/heads/master@{#37684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bbudge
Sorry, missed this.
4 years, 5 months ago (2016-07-12 14:00:02 UTC) #2
Benedikt Meurer
Nice, LGTM.
4 years, 5 months ago (2016-07-12 14:00:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144613002/1
4 years, 5 months ago (2016-07-12 15:00:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 15:02:55 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 15:04:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ddd158b7418c7819b6eb239a2d64181d6412aa1
Cr-Commit-Position: refs/heads/master@{#37684}

Powered by Google App Engine
This is Rietveld 408576698