Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: src/compiler/effect-control-linearizer.cc

Issue 2144603002: [turbofan] Remove some dead code from the EffectControlLinearizer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/effect-control-linearizer.cc
diff --git a/src/compiler/effect-control-linearizer.cc b/src/compiler/effect-control-linearizer.cc
index af52b6d626b5c32c17aca8326080f438a8c7e077..b80433c131a879849b8f62f893b3b3d28d956860 100644
--- a/src/compiler/effect-control-linearizer.cc
+++ b/src/compiler/effect-control-linearizer.cc
@@ -340,7 +340,6 @@ void EffectControlLinearizer::ProcessNode(Node* node, Node** frame_state,
// effect that is passed. The frame state is preserved for lowering.
DCHECK_EQ(RegionObservability::kObservable, region_observability_);
*frame_state = NodeProperties::GetFrameStateInput(node, 0);
- node->TrimInputCount(0);
return;
}
@@ -805,9 +804,6 @@ EffectControlLinearizer::LowerCheckBounds(Node* node, Node* frame_state,
control = effect = graph()->NewNode(common()->DeoptimizeUnless(), check,
frame_state, effect, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(index, effect, control);
}
@@ -838,9 +834,6 @@ EffectControlLinearizer::LowerCheckNumber(Node* node, Node* frame_state,
control = graph()->NewNode(common()->Merge(2), if_true0, if_false0);
effect = graph()->NewNode(common()->EffectPhi(2), etrue0, efalse0, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
@@ -852,9 +845,6 @@ EffectControlLinearizer::LowerCheckIf(Node* node, Node* frame_state,
control = effect = graph()->NewNode(common()->DeoptimizeUnless(), value,
frame_state, effect, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
@@ -867,9 +857,6 @@ EffectControlLinearizer::LowerCheckTaggedPointer(Node* node, Node* frame_state,
control = effect = graph()->NewNode(common()->DeoptimizeIf(), check,
frame_state, effect, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
@@ -882,9 +869,6 @@ EffectControlLinearizer::LowerCheckTaggedSigned(Node* node, Node* frame_state,
control = effect = graph()->NewNode(common()->DeoptimizeUnless(), check,
frame_state, effect, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
@@ -903,9 +887,6 @@ EffectControlLinearizer::LowerCheckedInt32Add(Node* node, Node* frame_state,
value = graph()->NewNode(common()->Projection(0), value, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
@@ -924,9 +905,6 @@ EffectControlLinearizer::LowerCheckedInt32Sub(Node* node, Node* frame_state,
value = graph()->NewNode(common()->Projection(0), value, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
@@ -1006,9 +984,6 @@ EffectControlLinearizer::LowerCheckedInt32Div(Node* node, Node* frame_state,
control = effect = graph()->NewNode(common()->DeoptimizeUnless(), check,
frame_state, effect, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
@@ -1082,9 +1057,6 @@ EffectControlLinearizer::LowerCheckedInt32Mod(Node* node, Node* frame_state,
graph()->NewNode(common()->Phi(MachineRepresentation::kWord32, 2), vtrue0,
vfalse0, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
@@ -1100,9 +1072,6 @@ EffectControlLinearizer::LowerCheckedUint32ToInt32(Node* node,
control = effect = graph()->NewNode(common()->DeoptimizeUnless(), is_safe,
frame_state, effect, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
@@ -1152,9 +1121,6 @@ EffectControlLinearizer::LowerCheckedFloat64ToInt32(Node* node,
Node* control) {
Node* value = node->InputAt(0);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return BuildCheckedFloat64ToInt32(value, frame_state, effect, control);
}
@@ -1202,9 +1168,6 @@ EffectControlLinearizer::LowerCheckedTaggedToInt32(Node* node,
value = graph()->NewNode(common()->Phi(MachineRepresentation::kWord32, 2),
vtrue, vfalse, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
@@ -1276,9 +1239,6 @@ EffectControlLinearizer::LowerCheckedTaggedToFloat64(Node* node,
graph()->NewNode(common()->Phi(MachineRepresentation::kFloat64, 2), vtrue,
number_state.value, merge);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(result, effect_phi, merge);
}
@@ -1639,9 +1599,6 @@ EffectControlLinearizer::LowerCheckFloat64Hole(Node* node, Node* frame_state,
control = effect = graph()->NewNode(common()->DeoptimizeIf(), check,
frame_state, effect, control);
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
@@ -1664,9 +1621,6 @@ EffectControlLinearizer::LowerCheckTaggedHole(Node* node, Node* frame_state,
break;
}
- // Make sure the lowered node does not appear in any use lists.
- node->TrimInputCount(0);
-
return ValueEffectControl(value, effect, control);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698