Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2144603002: [turbofan] Remove some dead code from the EffectControlLinearizer. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove some dead code from the EffectControlLinearizer. The manual input trimming inside the EffectControlLinearizer is no longer necessary, since we have to do explicit graph trimming before running the MemoryOptimizer anyways these days. R=jarin@chromium.org Committed: https://crrev.com/7ea8b9eca834af77a27be08949f613aeefa1a721 Cr-Commit-Position: refs/heads/master@{#37681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -46 lines) Patch
M src/compiler/effect-control-linearizer.cc View 16 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-12 12:49:22 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a simple cleanup. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-07-12 12:50:13 UTC) #4
Jarin
lgtm
4 years, 5 months ago (2016-07-12 12:59:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144603002/1
4 years, 5 months ago (2016-07-12 13:29:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 13:32:17 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 13:35:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ea8b9eca834af77a27be08949f613aeefa1a721
Cr-Commit-Position: refs/heads/master@{#37681}

Powered by Google App Engine
This is Rietveld 408576698