Issue 21446: Experimental: allow the register allocator to work for for...in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21446: Experimental: allow the register allocator to work for for...in... (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Experimental: allow the register allocator to work for for...in statements. This allows the iteration variable to be in a register for the body.

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+216 lines, -116 lines)			Patch
	M	src/codegen-ia32.cc	View		39 chunks	+216 lines, -116 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

This is tricky, because results taken from the frame can still occur in the frame ...

11 years, 10 months ago (2009-02-18 08:15:05 UTC) #1

William Hesse

11 years, 10 months ago (2009-02-18 10:33:27 UTC) #2

LGTM

http://codereview.chromium.org/21446/diff/1/2
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/21446/diff/1/2#newcode2499
Line 2499: if (temp.reg().is(entry.reg())) {
This cannot happen because entry.reg() is spilled above before creating temp. 
Assert that it can't happen.

Expand Messages | Collapse Messages