Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2144573004: SkRasterPipeline preliminaries (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
herb_g, mtklein
CC:
reed1, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkRasterPipeline preliminaries Re-uploading to see if I can get a CL number < 2^31. patch from issue 2147533002 at patchset 240001 (http://crrev.com/2147533002#ps240001) Already reviewed at the other crrev link. TBR= BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147533002 CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/281b33fdd909ee3f43192cdf950ce00e3df62407

Patch Set 1 #

Patch Set 2 : SK_VECTORCALL fixes #

Patch Set 3 : Explicit cast? #

Patch Set 4 : no lambdas #

Patch Set 5 : MSVC x86 vetoed lambdas. :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -0 lines) Patch
A bench/SkRasterPipelineBench.cpp View 1 1 chunk +195 lines, -0 lines 0 comments Download
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A src/core/SkRasterPipeline.h View 1 2 3 4 1 chunk +104 lines, -0 lines 0 comments Download
A src/core/SkRasterPipeline.cpp View 1 chunk +65 lines, -0 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 chunk +1 line, -0 lines 0 comments Download
A tests/SkRasterPipelineTest.cpp View 1 2 3 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (20 generated)
mtklein_C
This is the same as the other CL under a new CL number that's less ...
4 years, 5 months ago (2016-07-12 19:09:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144573004/1
4 years, 5 months ago (2016-07-12 19:09:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/9716) Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, ...
4 years, 5 months ago (2016-07-12 19:17:01 UTC) #7
herb_g
lgtm
4 years, 5 months ago (2016-07-12 19:29:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144573004/60001
4 years, 5 months ago (2016-07-12 20:25:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144573004/80001
4 years, 5 months ago (2016-07-12 20:57:16 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/281b33fdd909ee3f43192cdf950ce00e3df62407
4 years, 5 months ago (2016-07-12 22:01:30 UTC) #27
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 22:01:34 UTC) #28
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698