Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2144573003:
Temporarily disabling 2d canvas getImageData optimization (Closed)
|
Created:
4 years, 5 months ago by Justin Novosad Modified:
4 years, 5 months ago CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTemporarily disabling 2d canvas getImageData optimization
Disabling the optimization that makes getImageData disable
GPU acceleration in order to resolve a memory error.
BUG=626188, 627434
Committed: https://crrev.com/892c18d6f403629c7ba584e37d150f2334baa80c
Cr-Commit-Position: refs/heads/master@{#404919}
Patch Set 1 #Patch Set 2 : cleaner way #Patch Set 3 : fix test #Patch Set 4 : fix test 4 realz #
Messages
Total messages: 25 (14 generated)
junov@chromium.org changed reviewers: + xidachen@chromium.org, xlai@chromium.org
PTAL
lgtm
The CQ bit was checked by junov@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by junov@chromium.org
The CQ bit was checked by junov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xidachen@chromium.org, xlai@chromium.org Link to the patchset: https://codereview.chromium.org/2144573003/#ps20001 (title: "cleaner way")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by junov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xidachen@chromium.org, xlai@chromium.org Link to the patchset: https://codereview.chromium.org/2144573003/#ps40001 (title: "fix test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by junov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xidachen@chromium.org, xlai@chromium.org Link to the patchset: https://codereview.chromium.org/2144573003/#ps60001 (title: "fix test 4 realz")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Temporarily disabling 2d canvas getImageData optimization Disabling the optimization that makes getImageData disable GPU acceleration in order to resolve a memory error. BUG=626188 ========== to ========== Temporarily disabling 2d canvas getImageData optimization Disabling the optimization that makes getImageData disable GPU acceleration in order to resolve a memory error. BUG=626188,627434 ==========
Message was sent while issue was closed.
Description was changed from ========== Temporarily disabling 2d canvas getImageData optimization Disabling the optimization that makes getImageData disable GPU acceleration in order to resolve a memory error. BUG=626188,627434 ========== to ========== Temporarily disabling 2d canvas getImageData optimization Disabling the optimization that makes getImageData disable GPU acceleration in order to resolve a memory error. BUG=626188,627434 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Temporarily disabling 2d canvas getImageData optimization Disabling the optimization that makes getImageData disable GPU acceleration in order to resolve a memory error. BUG=626188,627434 ========== to ========== Temporarily disabling 2d canvas getImageData optimization Disabling the optimization that makes getImageData disable GPU acceleration in order to resolve a memory error. BUG=626188,627434 Committed: https://crrev.com/892c18d6f403629c7ba584e37d150f2334baa80c Cr-Commit-Position: refs/heads/master@{#404919} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/892c18d6f403629c7ba584e37d150f2334baa80c Cr-Commit-Position: refs/heads/master@{#404919} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
