chrome/browser/chrome_content_browser_client.cc - Issue 2144533002: Convert network hints to Mojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2144533002: Convert network hints to Mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add untracked dependency on mojom Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 3db8ffcf93b9f72ec2566445f896cd012b3901ac..0ab09d6fd5b9ec2a19a2413e6f08ba98a5bfc31e 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -967,7 +967,14 @@ void ChromeContentBrowserClient::RenderProcessWillLaunch(

net::URLRequestContextGetter* context =

host->GetStoragePartition()->GetURLRequestContext();

- host->AddFilter(new ChromeRenderMessageFilter(id, profile));

+ // The host owns both |chrome_render| and the interface registry, which will

+ // be destroyed before the filter.

+ auto* chrome_render_filter = new ChromeRenderMessageFilter(id, profile);

+ host->GetInterfaceRegistry()->AddInterface(

+ base::Bind(&ChromeRenderMessageFilter::BindNetworkHints,

+ base::Unretained(chrome_render_filter)),

dcheng 2016/07/25 02:50:47 Btw, I think we should just remove the base::Unret

+ BrowserThread::GetTaskRunnerForThread(BrowserThread::IO));

+ host->AddFilter(chrome_render_filter);

#if defined(ENABLE_EXTENSIONS)

host->AddFilter(new cast::CastTransportHostFilter);

#endif

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/extensions/BUILD.gn » ('j') | no next file with comments »