components/typemaps.gni - Issue 2144533002: Convert network hints to Mojo

Side by Side Diff: components/typemaps.gni

Issue 2144533002: Convert network hints to Mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change ownership of PrescientNetworkingDispatcher for proper shutdown Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/network_hints/renderer/renderer_preconnect.cc ('K') | « components/network_hints/renderer/renderer_preconnect.cc ('k') | ipc/ipc_message_start.h » ('j') | tools/ipc_fuzzer/message_lib/OWNERS » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 typemaps = [	5 typemaps = [

6 "//components/autofill/content/public/cpp/autofill_types.typemap",	6 "//components/autofill/content/public/cpp/autofill_types.typemap",

	7 "//components/network_hints/common/network_hints.typemap",
	blundell 2016/07/19 06:28:35 Why the divergence in directory structure for wher Why the divergence in directory structure for where the typemaps live? i.e., ".../public/cpp" vs. ".../<nothing>" vs. ".../public/interfaces" tibell 2016/07/19 07:06:10 We usually put them next to the .mojom, which begs Show quoted text On 2016/07/19 06:28:35, blundell wrote: > Why the divergence in directory structure for where the typemaps live? > > i.e., ".../public/cpp" vs. ".../<nothing>" vs. ".../public/interfaces" We usually put them next to the .mojom, which begs the question "where do we put the .mojom?". I chatted with some other mojo people and the answer seems to be in public/interfaces, so in this case it should really be in components/network_hints/public/interfaces/. I'll move it there. Sam McNally 2016/07/20 00:03:02 I'd prefer typemaps to live with the traits and/or Show quoted text On 2016/07/19 07:06:10, tibell wrote: > On 2016/07/19 06:28:35, blundell wrote: > > Why the divergence in directory structure for where the typemaps live? > > > > i.e., ".../public/cpp" vs. ".../<nothing>" vs. ".../public/interfaces" > > We usually put them next to the .mojom, which begs the question "where do we put > the .mojom?". I chatted with some other mojo people and the answer seems to be > in public/interfaces, so in this case it should really be in > components/network_hints/public/interfaces/. I'll move it there. I'd prefer typemaps to live with the traits and/or the C++ types. There can be multiple typemaps for a given mojom, and it doesn't make much sense for blink typemaps to live outside blink or chromium typemaps for blink mojoms to live in blink. tibell 2016/07/20 00:29:35 Done. Show quoted text On 2016/07/20 00:03:02, Sam McNally wrote: > On 2016/07/19 07:06:10, tibell wrote: > > On 2016/07/19 06:28:35, blundell wrote: > > > Why the divergence in directory structure for where the typemaps live? > > > > > > i.e., ".../public/cpp" vs. ".../<nothing>" vs. ".../public/interfaces" > > > > We usually put them next to the .mojom, which begs the question "where do we > put > > the .mojom?". I chatted with some other mojo people and the answer seems to be > > in public/interfaces, so in this case it should really be in > > components/network_hints/public/interfaces/. I'll move it there. > > I'd prefer typemaps to live with the traits and/or the C++ types. There can be > multiple typemaps for a given mojom, and it doesn't make much sense for blink > typemaps to live outside blink or chromium typemaps for blink mojoms to live in > blink. Done.
7 "//components/safe_json/public/interfaces/safe_json.typemap",	8 "//components/safe_json/public/interfaces/safe_json.typemap",

8 ]	9 ]

OLD	NEW