Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Side by Side Diff: Source/devtools/front_end/Dialog.js

Issue 214453003: [DevTools] Don't handle shortcuts while dialog is open. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/InspectorView.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 WebInspector.KeyboardShortcut.Keys.Esc.code, 52 WebInspector.KeyboardShortcut.Keys.Esc.code,
53 ]; 53 ];
54 54
55 delegate.show(this._element); 55 delegate.show(this._element);
56 56
57 this._position(); 57 this._position();
58 this._delegate.focus(); 58 this._delegate.focus();
59 } 59 }
60 60
61 /** 61 /**
62 * @return {!WebInspector.Dialog} 62 * @return {?WebInspector.Dialog}
63 */ 63 */
64 WebInspector.Dialog.currentInstance = function() 64 WebInspector.Dialog.currentInstance = function()
65 { 65 {
66 return WebInspector.Dialog._instance; 66 return WebInspector.Dialog._instance;
67 } 67 }
68 68
69 /** 69 /**
70 * @param {!Element} relativeToElement 70 * @param {!Element} relativeToElement
71 * @param {!WebInspector.DialogDelegate} delegate 71 * @param {!WebInspector.DialogDelegate} delegate
72 */ 72 */
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 { 198 {
199 return WebInspector.Dialog._modalHostView; 199 return WebInspector.Dialog._modalHostView;
200 }; 200 };
201 201
202 WebInspector.Dialog.modalHostRepositioned = function() 202 WebInspector.Dialog.modalHostRepositioned = function()
203 { 203 {
204 if (WebInspector.Dialog._instance) 204 if (WebInspector.Dialog._instance)
205 WebInspector.Dialog._instance._position(); 205 WebInspector.Dialog._instance._position();
206 }; 206 };
207 207
OLDNEW
« no previous file with comments | « no previous file | Source/devtools/front_end/InspectorView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698