Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2144523002: Remove obsolete SVG small font rejection (Closed)

Created:
4 years, 5 months ago by pdr.
Modified:
4 years, 5 months ago
Reviewers:
f(malita), fs
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete SVG small font rejection SVGInlineTextBoxPainter::textShouldBePainted was added in [1] to fix a Mac and QT rendering bug with small fonts. This workaround is no longer necessary with our new unified font rendering technology. [1] https://chromium.googlesource.com/chromium/src/+/f0aabc09b02b9792ebb18be5157456ada25c0039 BUG=626936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
A third_party/WebKit/LayoutTests/svg/text/minimum-text-size.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/text/minimum-text-size-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 3 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
pdr.
4 years, 5 months ago (2016-07-12 04:41:42 UTC) #3
f(malita)
LGTM, but the test is not passing on Win :( I presume it's because some ...
4 years, 5 months ago (2016-07-12 13:16:47 UTC) #8
pdr.
4 years, 5 months ago (2016-07-12 21:22:23 UTC) #9
Message was sent while issue was closed.
On 2016/07/12 at 13:16:47, fmalita wrote:
> LGTM, but the test is not passing on Win :(
> 
> I presume it's because some platform specific bit is not happy with the supper
tiny font we're picking.  If this is a DW limitation, we may have to block the
bug on http://crbug.com/294900.

Sadness, yeah, I guess this bug is still here with this gone. I'll comment on
the bug and close this.

Powered by Google App Engine
This is Rietveld 408576698