Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2144493002: deflake document-write-noscript.html (Closed)

Created:
4 years, 5 months ago by kouhei (in TOK)
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

deflake document-write-noscript.html Rewrite test using testharness.js + internals.isPreloaded BUG=436881 Committed: https://crrev.com/541b4f3f305b803e0a93803fa3de9c89075d481a Cr-Commit-Position: refs/heads/master@{#404783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/fast/preloader/document-write-noscript.html View 2 chunks +12 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/preloader/document-write-noscript-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kouhei (in TOK)
4 years, 5 months ago (2016-07-12 03:36:42 UTC) #3
kouhei (in TOK)
4 years, 5 months ago (2016-07-12 03:36:42 UTC) #4
haraken
LGTM
4 years, 5 months ago (2016-07-12 03:41:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144493002/1
4 years, 5 months ago (2016-07-12 03:42:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 05:13:08 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 05:13:26 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 05:14:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/541b4f3f305b803e0a93803fa3de9c89075d481a
Cr-Commit-Position: refs/heads/master@{#404783}

Powered by Google App Engine
This is Rietveld 408576698