Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2144473002: rewrite smil-leak tests to rely on layout test leak detector (Closed)

Created:
4 years, 5 months ago by kouhei (in TOK)
Modified:
4 years, 5 months ago
Reviewers:
haraken, hajimehoshi
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rewrite smil-leak tests to rely on layout test leak detector This CL modifies the tests to rely on Blink Leak Detector instead of doing leak check manually on each test. BUG=516364 Committed: https://crrev.com/3419088c0915f789c3e52439887a339dc90a8df8 Cr-Commit-Position: refs/heads/master@{#404784}

Patch Set 1 #

Messages

Total messages: 14 (6 generated)
kouhei (in TOK)
4 years, 5 months ago (2016-07-12 02:22:33 UTC) #2
haraken
LGTM
4 years, 5 months ago (2016-07-12 02:24:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144473002/1
4 years, 5 months ago (2016-07-12 02:30:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/253698)
4 years, 5 months ago (2016-07-12 03:54:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144473002/1
4 years, 5 months ago (2016-07-12 03:56:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 05:16:30 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 05:16:39 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 05:17:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3419088c0915f789c3e52439887a339dc90a8df8
Cr-Commit-Position: refs/heads/master@{#404784}

Powered by Google App Engine
This is Rietveld 408576698