Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2144453002:
MD Settings: Fix editing name of default search engine. (Closed)
|
Created:
4 years, 5 months ago by dpapad Modified:
4 years, 5 months ago Reviewers:
Dan Beam CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Fix editing name of default search engine.
When editing the default search engine's name, the "(Default)"
suffix should not be displayed in the textbox.
BUG=626767
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/17ea31cf6ab7e0ed11445feaf94e6b3352350e01
Cr-Commit-Position: refs/heads/master@{#404979}
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== MD Settings: Fix editing name of default search engine. BUG=626767 ========== to ========== MD Settings: Fix editing name of default search engine. BUG=626767 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD Settings: Fix editing name of default search engine. BUG=626767 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Fix editing name of default search engine. When editing the default search engine's name, the "(Default)" suffix should not be displayed in the textbox. BUG=626767 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
dpapad@chromium.org changed reviewers: + dbeam@chromium.org
Before/after screenshots http://imgur.com/a/F7Pmg.
lgtm thanks for this fix and the test!
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dpapad@chromium.org
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Fix editing name of default search engine. When editing the default search engine's name, the "(Default)" suffix should not be displayed in the textbox. BUG=626767 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Fix editing name of default search engine. When editing the default search engine's name, the "(Default)" suffix should not be displayed in the textbox. BUG=626767 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/17ea31cf6ab7e0ed11445feaf94e6b3352350e01 Cr-Commit-Position: refs/heads/master@{#404979} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/17ea31cf6ab7e0ed11445feaf94e6b3352350e01 Cr-Commit-Position: refs/heads/master@{#404979} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
