[android] Correct the URL scheme colors in the Omnibox.

[android] Correct the URL scheme colors in the Omnibox.

Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.

BUG=626646
TBR=tedchoc

Committed: https://crrev.com/cfd0445d8d4756d778e1b324dc739a7c1e51b128
Cr-Commit-Position: refs/heads/master@{#405258}

[palmer, 2016-07-11 23:26:56]

palmer@chromium.org changed reviewers:
+ nyquist@chromium.org, tedchoc@chromium.org

[palmer, 2016-07-11 23:26:57]

nyquist: Since tedchoc is OOO, can you PTAL? This is a follow-up to
https://codereview.chromium.org/2063823005/. Thanks!

[palmer, 2016-07-11 23:56:51]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 23:57:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 00:18:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 00:18:53]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[palmer, 2016-07-12 00:22:51]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 00:24:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 01:17:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 01:17:06]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[palmer, 2016-07-12 01:23:58]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 01:25:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 02:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 02:49:59]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nyquist, 2016-07-12 23:46:00]

lgtm.

But do you think you could expand the CL description a little bit more, so
people reading the git log later don't have to look up the bug?

Maybe having three sentences or paragraphs answering these questions:
- What is happening now?
- Why is that bad?
- How does this CL make it better?

https://codereview.chromium.org/2144443002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java
(right):

https://codereview.chromium.org/2144443002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java:155:
case ConnectionSecurityLevel.NONE:
Nit: Could you add a trailing comment:
  // Intentional fall through.
here and for EV_SECURE?

[palmer, 2016-07-13 00:45:05]

Description was changed from

==========
[android] Correct the URL scheme colors in the Omnibox.

BUG=626646
==========

to

==========
[android] Correct the URL scheme colors in the Omnibox.

Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.

BUG=626646
==========

[palmer, 2016-07-13 00:45:29]

https://codereview.chromium.org/2144443002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java
(right):

https://codereview.chromium.org/2144443002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java:155:
case ConnectionSecurityLevel.NONE:
On 2016/07/12 23:46:00, nyquist wrote:
> Nit: Could you add a trailing comment:
>   // Intentional fall through.
> here and for EV_SECURE?

Done.

[palmer, 2016-07-13 00:45:49]

The CQ bit was checked by palmer@chromium.org

[palmer, 2016-07-13 00:45:50]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/2144443002/#ps100001
(title: "Respond to comments.")

[commit-bot: I haz the power, 2016-07-13 00:49:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:45:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 02:45:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[palmer, 2016-07-13 19:46:43]

Description was changed from

==========
[android] Correct the URL scheme colors in the Omnibox.

Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.

BUG=626646
==========

to

==========
[android] Correct the URL scheme colors in the Omnibox.

Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.

BUG=626646
TBR=tedchoc
==========

[palmer, 2016-07-13 19:47:09]

On 2016/07/13 02:45:57, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

tedchoc: TBRing you for the colors.xml change.

[palmer, 2016-07-13 19:47:18]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2016-07-13 19:49:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 20:11:53]

Description was changed from

==========
[android] Correct the URL scheme colors in the Omnibox.

Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.

BUG=626646
TBR=tedchoc
==========

to

==========
[android] Correct the URL scheme colors in the Omnibox.

Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.

BUG=626646
TBR=tedchoc
==========

[commit-bot: I haz the power, 2016-07-13 20:11:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-13 20:12:16]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 20:14:23]

Description was changed from

==========
[android] Correct the URL scheme colors in the Omnibox.

Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.

BUG=626646
TBR=tedchoc
==========

to

==========
[android] Correct the URL scheme colors in the Omnibox.

Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.

BUG=626646
TBR=tedchoc

Committed: https://crrev.com/cfd0445d8d4756d778e1b324dc739a7c1e51b128
Cr-Commit-Position: refs/heads/master@{#405258}
==========

[commit-bot: I haz the power, 2016-07-13 20:14:25]

Patchset 6 (id:??) landed as
https://crrev.com/cfd0445d8d4756d778e1b324dc739a7c1e51b128
Cr-Commit-Position: refs/heads/master@{#405258}

[palmer, 2016-07-13 23:08:50]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2150493003/ by palmer@chromium.org.

The reason for reverting is: Assertion failures (?) in things that don't run
during CQ:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test....

[qinmin, 2016-07-13 23:09:24]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2145243002/ by qinmin@chromium.org.

The reason for reverting is: This change breaks Android Tests(dbg) bot, see logs
here:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test....