Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214443007: Pass location and description of local printers into print preview. (Closed)

Created:
6 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Pass location and description of local printers into print preview. OSX already uses description as display name for printers, so pass printer model instead. BUG=256223 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260383

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -11 lines) Patch
M chrome/browser/resources/print_preview/data/local_parsers.js View 1 2 3 4 4 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 2 chunks +20 lines, -2 lines 0 comments Download
M printing/print_job_constants.h View 1 1 chunk +6 lines, -4 lines 0 comments Download
M printing/print_job_constants.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 8 months ago (2014-03-28 18:11:18 UTC) #1
Noam Samuel
lgtm https://codereview.chromium.org/214443007/diff/20001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/214443007/diff/20001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode290 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:290: printers->Append(printer_info); Why move this here? IMO this makes ...
6 years, 8 months ago (2014-03-28 18:19:31 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/214443007/diff/20001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/214443007/diff/20001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode290 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:290: printers->Append(printer_info); On 2014/03/28 18:19:31, Noam Samuel wrote: > Why ...
6 years, 8 months ago (2014-03-28 18:23:04 UTC) #3
Noam Samuel
https://codereview.chromium.org/214443007/diff/20001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/214443007/diff/20001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode290 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:290: printers->Append(printer_info); On 2014/03/28 18:23:04, Vitaly Buka wrote: > On ...
6 years, 8 months ago (2014-03-28 18:24:09 UTC) #4
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-03-28 19:40:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/214443007/20001
6 years, 8 months ago (2014-03-28 19:43:08 UTC) #6
Aleksey Shlyapnikov
https://codereview.chromium.org/214443007/diff/20001/chrome/browser/resources/print_preview/data/local_parsers.js File chrome/browser/resources/print_preview/data/local_parsers.js (right): https://codereview.chromium.org/214443007/diff/20001/chrome/browser/resources/print_preview/data/local_parsers.js#newcode20 chrome/browser/resources/print_preview/data/local_parsers.js:20: return "__cp__" + key + "=" + this[key] I'd ...
6 years, 8 months ago (2014-03-28 20:26:16 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 8 months ago (2014-03-28 20:30:55 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-03-28 20:45:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/214443007/60001
6 years, 8 months ago (2014-03-28 20:50:16 UTC) #10
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-03-29 00:09:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/214443007/80001
6 years, 8 months ago (2014-03-29 00:13:03 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 01:50:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 01:50:59 UTC) #14
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-03-29 01:52:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/214443007/80001
6 years, 8 months ago (2014-03-29 01:53:21 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 03:22:18 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 03:22:19 UTC) #18
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-03-29 04:29:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/214443007/80001
6 years, 8 months ago (2014-03-29 04:29:37 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 06:04:48 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 06:04:49 UTC) #22
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-03-29 06:59:20 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/214443007/80001
6 years, 8 months ago (2014-03-29 06:59:58 UTC) #24
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 17:39:56 UTC) #25
Message was sent while issue was closed. 
Change committed as 260383

Powered by Google App Engine
This is Rietveld 408576698