Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214443003: DevTools: Start/Stop timeline overview recording for available mode (Closed)

Created:
6 years, 9 months ago by Pan
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: Start/Stop overview recording for available mode BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170330

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Total comments: 3

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M Source/devtools/front_end/TimelinePanel.js View 1 2 3 4 4 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Pan
Hi @pfeldman, I should start/stop overview recording only for the available modes. This also cause ...
6 years, 9 months ago (2014-03-27 13:54:50 UTC) #1
pfeldman
Let me think this through!
6 years, 9 months ago (2014-03-27 15:07:00 UTC) #2
Pan
https://codereview.chromium.org/214443003/diff/60001/Source/devtools/front_end/TimelinePanel.js File Source/devtools/front_end/TimelinePanel.js (right): https://codereview.chromium.org/214443003/diff/60001/Source/devtools/front_end/TimelinePanel.js#newcode587 Source/devtools/front_end/TimelinePanel.js:587: for (var mode in this._availableModes()) w/o this change, the ...
6 years, 9 months ago (2014-03-28 09:16:21 UTC) #3
pfeldman
lgtm Gotcha. A little nit and this can be landed. https://codereview.chromium.org/214443003/diff/60001/Source/devtools/front_end/TimelinePanel.js File Source/devtools/front_end/TimelinePanel.js (right): https://codereview.chromium.org/214443003/diff/60001/Source/devtools/front_end/TimelinePanel.js#newcode242 ...
6 years, 9 months ago (2014-03-28 09:46:35 UTC) #4
Pan
https://codereview.chromium.org/214443003/diff/60001/Source/devtools/front_end/TimelinePanel.js File Source/devtools/front_end/TimelinePanel.js (right): https://codereview.chromium.org/214443003/diff/60001/Source/devtools/front_end/TimelinePanel.js#newcode242 Source/devtools/front_end/TimelinePanel.js:242: this._modes = JSON.parse(JSON.stringify(WebInspector.TimelinePanel.Mode)); On 2014/03/28 09:46:35, pfeldman wrote: > ...
6 years, 9 months ago (2014-03-28 13:01:08 UTC) #5
Pan
The CQ bit was checked by pan.deng@intel.com
6 years, 9 months ago (2014-03-28 13:01:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/214443003/80001
6 years, 9 months ago (2014-03-28 13:01:17 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 13:39:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-28 13:39:31 UTC) #9
Pan
The CQ bit was checked by pan.deng@intel.com
6 years, 9 months ago (2014-03-28 14:03:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/214443003/80001
6 years, 9 months ago (2014-03-28 14:03:53 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 14:38:38 UTC) #12
Message was sent while issue was closed. 
Change committed as 170330

Powered by Google App Engine
This is Rietveld 408576698