chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java - Issue 2144423002: [Offline Pages] Fixing bookmarking offline page will save file path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Issue 2144423002: [Offline Pages] Fixing bookmarking offline page will save file path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more related changes. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

index cd416e25317e5ed7cbe78df2d0041441aa946ab8..106027043db0a10c3070b964590dfbeb35bdde21 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

@@ -200,8 +200,8 @@ public class OfflinePageUtils {

Tab foundTab = tabModelSelector.getTabById(tabId);

if (foundTab == null) return;

- LoadUrlParams params = new LoadUrlParams(

- foundTab.getOfflinePageOriginalUrl(), PageTransition.RELOAD);

+ LoadUrlParams params =

+ new LoadUrlParams(foundTab.getOriginalUrl(), PageTransition.RELOAD);

foundTab.loadUrl(params);

}