chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2144423002: [Offline Pages] Fixing bookmarking offline page will save file path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2144423002: [Offline Pages] Fixing bookmarking offline page will save file path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more related changes. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index 1c9be71a40c3ac32b0637d97de9ed48f1d5dcb81..a415606bd43b47f7e16bd0cf7b603d2f5789bdc1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -963,7 +963,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

@Override

public void onFinishGetBitmap(Bitmap bitmap, int response) {

// Check whether this page is an offline page, and use its online URL if so.

- String url = currentTab.getOfflinePageOriginalUrl();

+ String url = currentTab.getOriginalUrl();

RecordHistogram.recordBooleanHistogram(

"OfflinePages.SharedPageWasOffline", url != null);

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java » ('j') | no next file with comments »