third_party/WebKit/Source/core/paint/BlockPainter.cpp - Issue 2144413002: Fix invalidation under scroll, and cull rect testing, of flipped-block writing mode elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BlockPainter.cpp

Issue 2144413002: Fix invalidation under scroll, and cull rect testing, of flipped-block writing mode elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: none Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutObject.cpp ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/BlockPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/BlockPainter.cpp b/third_party/WebKit/Source/core/paint/BlockPainter.cpp

index ae250bfccabca4a2900c7f12483378e5d69586fd..6db51a6b94d7011f8b0b4138b7331af155f3495c 100644

--- a/third_party/WebKit/Source/core/paint/BlockPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/BlockPainter.cpp

@@ -227,10 +227,12 @@ bool BlockPainter::intersectsPaintRect(const PaintInfo& paintInfo, const LayoutP

overflowRect.unite(m_layoutBlock.visualOverflowRect());

if (m_layoutBlock.hasOverflowModel() && m_layoutBlock.usesCompositedScrolling()) {

- overflowRect.unite(m_layoutBlock.layoutOverflowRect());

- overflowRect.move(-m_layoutBlock.scrolledContentOffset());

+ LayoutRect layoutOverflowRect = m_layoutBlock.layoutOverflowRect();

+ m_layoutBlock.flipForWritingMode(layoutOverflowRect);

+ layoutOverflowRect.move(-m_layoutBlock.scrolledContentOffset());

+ overflowRect.unite(layoutOverflowRect);

}

- m_layoutBlock.flipForWritingMode(overflowRect);

overflowRect.moveBy(adjustedPaintOffset);

return paintInfo.cullRect().intersectsCullRect(overflowRect);

}