Fix invalidation under scroll, and cull rect testing, of flipped-block writing mode elements.

Fix invalidation under scroll, and cull rect testing, of flipped-block writing mode elements.

BUG=529938
Committed: https://crrev.com/799bc86d81b9a6efb6aac2ce1bbbe32a907bccb8
Cr-Commit-Position: refs/heads/master@{#405891}

[chrishtr, 2016-07-14 22:51:15]

Description was changed from

==========
none


none


none


none


none


none


none


none


none


none

BUG=
==========

to

==========
Fix invalidation under scroll, and cull rect testing, of flipped-block writing
mode elements.
==========

[chrishtr, 2016-07-14 22:59:59]

chrishtr@chromium.org changed reviewers:
+ wkorman@chromium.org

[chrishtr, 2016-07-14 23:00:05]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 23:00:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2016-07-14 23:48:52]

lgtm

https://codereview.chromium.org/2144413002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2144413002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1400: inverseOffset =
inverseOffset + toLayoutSize(LayoutPoint(scrollableArea->scrollOrigin()));
nit: could use += and rm the rhs inverseOffset

[chrishtr, 2016-07-14 23:51:10]

https://codereview.chromium.org/2144413002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2144413002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1400: inverseOffset =
inverseOffset + toLayoutSize(LayoutPoint(scrollableArea->scrollOrigin()));
On 2016/07/14 at 23:48:52, wkorman wrote:
> nit: could use += and rm the rhs inverseOffset

Done.

[chrishtr, 2016-07-14 23:51:13]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-14 23:51:13]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2144413002/#ps40001
(title: "none")

[commit-bot: I haz the power, 2016-07-14 23:51:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 00:47:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 00:47:07]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2016-07-15 19:01:41]

Updated to move scroll origin to offsetFromLayoutObject, and reverted a bunch of
the other
stuff. Added a comment to BlockPainter.

[chrishtr, 2016-07-15 19:01:47]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 19:02:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-07-15 19:18:50]

Description was changed from

==========
Fix invalidation under scroll, and cull rect testing, of flipped-block writing
mode elements.
==========

to

==========
Fix invalidation under scroll, and cull rect testing, of flipped-block writing
mode elements.

BUG=529938
==========

[chrishtr, 2016-07-15 20:45:43]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-07-15 20:45:45]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-15 20:45:45]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2144413002/#ps120001
(title: "none")

[commit-bot: I haz the power, 2016-07-15 20:46:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 23:06:51]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-15 23:07:01]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 23:08:13]

Description was changed from

==========
Fix invalidation under scroll, and cull rect testing, of flipped-block writing
mode elements.

BUG=529938
==========

to

==========
Fix invalidation under scroll, and cull rect testing, of flipped-block writing
mode elements.

BUG=529938

Committed: https://crrev.com/799bc86d81b9a6efb6aac2ce1bbbe32a907bccb8
Cr-Commit-Position: refs/heads/master@{#405891}
==========

[commit-bot: I haz the power, 2016-07-15 23:08:14]

Patchset 7 (id:??) landed as
https://crrev.com/799bc86d81b9a6efb6aac2ce1bbbe32a907bccb8
Cr-Commit-Position: refs/heads/master@{#405891}