Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 21444002: Do not restore corrupt cached app window bounds. (Closed)

Created:
7 years, 4 months ago by scheib
Modified:
7 years, 4 months ago
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Do not restore corrupt cached app window bounds. Corrupted cached bounds happen durring development, and possibly to all users. This change hardens the loading code to not use invalid cached state. Related clean up in shell_window for adjusting screen bounds as well. BUG=266578 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215098

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : fix browser tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -29 lines) Patch
M apps/shell_window.cc View 1 2 4 chunks +14 lines, -22 lines 0 comments Download
M apps/shell_window_geometry_cache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/shell_window_geometry_cache.cc View 1 1 chunk +13 lines, -5 lines 0 comments Download
M apps/shell_window_geometry_cache_unittest.cc View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scheib
7 years, 4 months ago (2013-08-01 00:16:38 UTC) #1
Ken Rockot(use gerrit already)
Just a nit and lgtm https://codereview.chromium.org/21444002/diff/1/apps/shell_window_geometry_cache.cc File apps/shell_window_geometry_cache.cc (right): https://codereview.chromium.org/21444002/diff/1/apps/shell_window_geometry_cache.cc#newcode162 apps/shell_window_geometry_cache.cc:162: nit: It might be ...
7 years, 4 months ago (2013-08-01 01:04:49 UTC) #2
scheib
asargent, owners please
7 years, 4 months ago (2013-08-01 04:16:09 UTC) #3
asargent_no_longer_on_chrome
lgtm BTW, looks like you have compile error on browser tests
7 years, 4 months ago (2013-08-01 04:49:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/21444002/18001
7 years, 4 months ago (2013-08-01 18:01:51 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-01 20:12:47 UTC) #6
Message was sent while issue was closed.
Change committed as 215098

Powered by Google App Engine
This is Rietveld 408576698