Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2684)

Unified Diff: cc/test/test_delegating_output_surface.h

Issue 2144393003: cc: Allow TestDelegatingOutputSurface to be used for non-pixel tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/pixel_test_delegating_output_surface.cc ('k') | cc/test/test_delegating_output_surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/test_delegating_output_surface.h
diff --git a/cc/test/pixel_test_delegating_output_surface.h b/cc/test/test_delegating_output_surface.h
similarity index 56%
rename from cc/test/pixel_test_delegating_output_surface.h
rename to cc/test/test_delegating_output_surface.h
index e27e52bb09bf6bc0b41f39ec9936a029cc36f746..ed22b4bfe2d81c496b8ffe5a0bb1fbffe1fad09b 100644
--- a/cc/test/pixel_test_delegating_output_surface.h
+++ b/cc/test/test_delegating_output_surface.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CC_TEST_PIXEL_TEST_DELEGATING_OUTPUT_SURFACE_H_
-#define CC_TEST_PIXEL_TEST_DELEGATING_OUTPUT_SURFACE_H_
+#ifndef CC_TEST_TEST_DELEGATING_OUTPUT_SURFACE_H_
+#define CC_TEST_TEST_DELEGATING_OUTPUT_SURFACE_H_
#include "base/memory/weak_ptr.h"
#include "cc/output/output_surface.h"
@@ -18,20 +18,16 @@
namespace cc {
-class PixelTestDelegatingOutputSurface : public OutputSurface,
- public SurfaceFactoryClient {
+class TestDelegatingOutputSurface : public OutputSurface,
+ public SurfaceFactoryClient {
public:
- PixelTestDelegatingOutputSurface(
+ TestDelegatingOutputSurface(
scoped_refptr<ContextProvider> compositor_context_provider,
scoped_refptr<ContextProvider> worker_context_provider,
- scoped_refptr<ContextProvider> display_context_provider,
- const RendererSettings& renderer_settings,
- SharedBitmapManager* shared_bitmap_manager,
- gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
- const gfx::Size& surface_expansion_size,
- bool allow_force_reclaim_resources,
- bool synchronous_composite);
- ~PixelTestDelegatingOutputSurface() override;
+ std::unique_ptr<Display> display,
+ bool context_shared_with_compositor,
+ bool allow_force_reclaim_resources);
+ ~TestDelegatingOutputSurface() override;
// OutputSurface implementation.
bool BindToClient(OutputSurfaceClient* client) override;
@@ -45,11 +41,6 @@ class PixelTestDelegatingOutputSurface : public OutputSurface,
void ReturnResources(const ReturnedResourceArray& resources) override;
void SetBeginFrameSource(BeginFrameSource* begin_frame_source) override;
- // Allow tests to enlarge the backing texture for a non-root render pass, to
- // simulate reusing a larger texture from a previous frame for a new
- // render pass. This should be called before the output surface is bound.
- void SetEnlargePassTextureAmount(const gfx::Size& amount);
-
private:
void DrawCallback(SurfaceDrawStatus);
@@ -58,18 +49,6 @@ class PixelTestDelegatingOutputSurface : public OutputSurface,
void DisplaySetMemoryPolicy(const ManagedMemoryPolicy& policy) override {}
};
- SharedBitmapManager* const shared_bitmap_manager_;
- gpu::GpuMemoryBufferManager* const gpu_memory_buffer_manager_;
- const gfx::Size surface_expansion_size_;
- const bool allow_force_reclaim_resources_;
- const bool synchronous_composite_;
- const RendererSettings renderer_settings_;
-
- // Passed to the Display.
- scoped_refptr<ContextProvider> display_context_provider_;
-
- gfx::Size enlarge_pass_texture_amount_;
-
// TODO(danakj): These don't to be stored in unique_ptrs when OutputSurface
// is owned/destroyed on the compositor thread.
std::unique_ptr<SurfaceManager> surface_manager_;
@@ -83,9 +62,9 @@ class PixelTestDelegatingOutputSurface : public OutputSurface,
// Uses surface_manager_.
std::unique_ptr<Display> display_;
- base::WeakPtrFactory<PixelTestDelegatingOutputSurface> weak_ptrs_;
+ base::WeakPtrFactory<TestDelegatingOutputSurface> weak_ptrs_;
};
} // namespace cc
-#endif // CC_TEST_PIXEL_TEST_DELEGATING_OUTPUT_SURFACE_H_
+#endif // CC_TEST_TEST_DELEGATING_OUTPUT_SURFACE_H_
« no previous file with comments | « cc/test/pixel_test_delegating_output_surface.cc ('k') | cc/test/test_delegating_output_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698