Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2144393003: cc: Allow TestDelegatingOutputSurface to be used for non-pixel tests. (Closed)

Created:
4 years, 5 months ago by danakj
Modified:
4 years, 5 months ago
CC:
android-webview-reviews_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, jochen+watch_chromium.org, kalyank, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, piman, rjkroege, sievers+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Allow TestDelegatingOutputSurface to be used for non-pixel tests. This renames the PixelTestDelegatingOutputSurface to drop the "Pixel", it's cleaner. And the caller creates the Display and its OutputSurface, etc. So it has control over the types and can use a PixelTestOutputSurface or a FakeOutputSurface for non-pixel unit tests. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/516efc062a05c933e7ec957684235bdd6b9f3b87 Cr-Commit-Position: refs/heads/master@{#405623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -409 lines) Patch
M android_webview/browser/surfaces_instance.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M cc/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/surfaces/display.h View 3 chunks +11 lines, -8 lines 0 comments Download
M cc/surfaces/display.cc View 2 chunks +15 lines, -15 lines 0 comments Download
M cc/surfaces/display_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/surfaces/surface_display_output_surface_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/layer_tree_pixel_test.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 2 chunks +52 lines, -22 lines 0 comments Download
D cc/test/pixel_test_delegating_output_surface.h View 1 chunk +0 lines, -91 lines 0 comments Download
D cc/test/pixel_test_delegating_output_surface.cc View 1 chunk +0 lines, -185 lines 0 comments Download
A + cc/test/test_delegating_output_surface.h View 5 chunks +11 lines, -32 lines 0 comments Download
A cc/test/test_delegating_output_surface.cc View 1 chunk +132 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/renderer/android/synchronous_compositor_output_surface.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +43 lines, -15 lines 0 comments Download
M services/ui/surfaces/display_compositor.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
danakj
4 years, 5 months ago (2016-07-14 22:08:14 UTC) #2
danakj
+piman for content +boliu for webview +fsamuel for mus
4 years, 5 months ago (2016-07-14 22:08:53 UTC) #4
enne (OOO)
lgtm
4 years, 5 months ago (2016-07-14 23:03:11 UTC) #7
Fady Samuel
lgtm
4 years, 5 months ago (2016-07-14 23:03:46 UTC) #8
boliu
rs lgtm
4 years, 5 months ago (2016-07-14 23:06:09 UTC) #9
piman
lgtm
4 years, 5 months ago (2016-07-14 23:12:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144393003/1
4 years, 5 months ago (2016-07-14 23:16:37 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 23:24:22 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 23:27:04 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/516efc062a05c933e7ec957684235bdd6b9f3b87
Cr-Commit-Position: refs/heads/master@{#405623}

Powered by Google App Engine
This is Rietveld 408576698