Remove failing expectation for layout test GUM-trivial-constraint.https.html.

Remove failing expectation for layout test GUM-trivial-constraint.https.html.

Reason: This test seems to be passing consistently now, both on the waterfall and on my machine.

BUG=412381, 508725
Committed: https://crrev.com/fc28338d5f0794c276f7f4bb6f3a3b15c076a77f
Cr-Commit-Position: refs/heads/master@{#405822}

[qyearsley, 2016-07-14 22:04:54]

Description was changed from

==========
Remove failing expectation for layout test GUM-trivial-constraint.https.html.

BUG=412381
==========

to

==========
Remove failing expectation for layout test GUM-trivial-constraint.https.html.

Reason: This test seems to be passing consistently now, both on the waterfall
and on my machine.

BUG=412381,508725
==========

[qyearsley, 2016-07-14 22:05:02]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 22:05:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2016-07-14 22:06:45]

qyearsley@chromium.org changed reviewers:
+ hta@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:18:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:18:20]

Dry run: This issue passed the CQ dry run.

[blink-reviews, 2016-07-15 08:49:58]

Lgtm

15. jul. 2016 12:06 a.m. skrev <qyearsley@chromium.org>:

> Reviewers: hta - Chromium
> CL: https://codereview.chromium.org/2144393002/
>
> Description:
> Remove failing expectation for layout test
> GUM-trivial-constraint.https.html.
>
> Reason: This test seems to be passing consistently now, both on the
> waterfall
> and on my machine.
>
> BUG=412381,508725
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+1, -3 lines):
> M third_party/WebKit/LayoutTests/TestExpectations
> M third_party/WebKit/LayoutTests/WPTServeExpectations
>
>
> Index: third_party/WebKit/LayoutTests/TestExpectations
> diff --git a/third_party/WebKit/LayoutTests/TestExpectations
> b/third_party/WebKit/LayoutTests/TestExpectations
> index
>
4095076db04576e361b9a3216fd2d83276e0673a..c672c648b44496560e17be5257135f0b6471e8d0
> 100644
> --- a/third_party/WebKit/LayoutTests/TestExpectations
> +++ b/third_party/WebKit/LayoutTests/TestExpectations
> @@ -469,7 +469,6 @@ crbug.com/387740
> imported/wpt/mediacapture-streams/MediaStream-idl.https.html [
> crbug.com/387740
> imported/wpt/mediacapture-streams/MediaStream-removetrack.https.html [ Skip
> ]
>
> crbug.com/412381
> imported/wpt/mediacapture-streams/GUM-empty-option-param.https.html [
> Failure ]
> -crbug.com/412381
> imported/wpt/mediacapture-streams/GUM-trivial-constraint.https.html [
> Failure ]
> crbug.com/412381
> imported/wpt/mediacapture-streams/GUM-unknownkey-option-param.https.html [
> Failure ]
> crbug.com/412381
>
imported/wpt/mediacapture-streams/MediaStream-MediaElement-preload-none.https.html
> [ Pass Timeout Failure ]
>
> @@ -1388,4 +1387,4 @@ crbug.com/627844
> virtual/gpu-rasterization/fast/images/color-profile-svg.html [
> crbug.com/627844
>
virtual/gpu-rasterization/fast/images/color-profile-background-image-cover.html
> [ NeedsManualRebaseline ]
> crbug.com/627844
> virtual/gpu-rasterization/fast/images/color-profile-object.html [
> NeedsManualRebaseline ]
> crbug.com/627844
> virtual/gpu-rasterization/fast/images/ycbcr-with-cmyk-color-profile.html [
> NeedsManualRebaseline ]
> -crbug.com/627844
> virtual/gpu/fast/canvas/canvas-createImageBitmap-colorClamping.html [ Pass
> Failure ]
> \ No newline at end of file
> +crbug.com/627844
> virtual/gpu/fast/canvas/canvas-createImageBitmap-colorClamping.html [ Pass
> Failure ]
> Index: third_party/WebKit/LayoutTests/WPTServeExpectations
> diff --git a/third_party/WebKit/LayoutTests/WPTServeExpectations
> b/third_party/WebKit/LayoutTests/WPTServeExpectations
> index
>
3ac88330f0c9b4e38de96010dcfbc86c9c971570..474a6c47b033cdf60d277ceaae76527819caae1c
> 100644
> --- a/third_party/WebKit/LayoutTests/WPTServeExpectations
> +++ b/third_party/WebKit/LayoutTests/WPTServeExpectations
> @@ -44,7 +44,6 @@ crbug.com/508725
> imported/wpt/html/webappapis/system-state-and-capabilities/the-
> # Expectation is [ Pass ] since for these there is no -expected.txt,
> # but instead there is a [ Failure ] expectation in TestExpectations.
> crbug.com/508725
>
imported/wpt/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script.html
> [ Pass ]
> -crbug.com/508725
> imported/wpt/mediacapture-streams/GUM-trivial-constraint.https.html [ Pass ]
> crbug.com/508725 imported/wpt/pointerevents/pointerevent_constructor.html
> [ Pass ]
>
> # These tests timeout with --enable-wptserve enabled.
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-07-15 08:49:58]

Lgtm

15. jul. 2016 12:06 a.m. skrev <qyearsley@chromium.org>:

> Reviewers: hta - Chromium
> CL: https://codereview.chromium.org/2144393002/
>
> Description:
> Remove failing expectation for layout test
> GUM-trivial-constraint.https.html.
>
> Reason: This test seems to be passing consistently now, both on the
> waterfall
> and on my machine.
>
> BUG=412381,508725
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+1, -3 lines):
> M third_party/WebKit/LayoutTests/TestExpectations
> M third_party/WebKit/LayoutTests/WPTServeExpectations
>
>
> Index: third_party/WebKit/LayoutTests/TestExpectations
> diff --git a/third_party/WebKit/LayoutTests/TestExpectations
> b/third_party/WebKit/LayoutTests/TestExpectations
> index
>
4095076db04576e361b9a3216fd2d83276e0673a..c672c648b44496560e17be5257135f0b6471e8d0
> 100644
> --- a/third_party/WebKit/LayoutTests/TestExpectations
> +++ b/third_party/WebKit/LayoutTests/TestExpectations
> @@ -469,7 +469,6 @@ crbug.com/387740
> imported/wpt/mediacapture-streams/MediaStream-idl.https.html [
> crbug.com/387740
> imported/wpt/mediacapture-streams/MediaStream-removetrack.https.html [ Skip
> ]
>
> crbug.com/412381
> imported/wpt/mediacapture-streams/GUM-empty-option-param.https.html [
> Failure ]
> -crbug.com/412381
> imported/wpt/mediacapture-streams/GUM-trivial-constraint.https.html [
> Failure ]
> crbug.com/412381
> imported/wpt/mediacapture-streams/GUM-unknownkey-option-param.https.html [
> Failure ]
> crbug.com/412381
>
imported/wpt/mediacapture-streams/MediaStream-MediaElement-preload-none.https.html
> [ Pass Timeout Failure ]
>
> @@ -1388,4 +1387,4 @@ crbug.com/627844
> virtual/gpu-rasterization/fast/images/color-profile-svg.html [
> crbug.com/627844
>
virtual/gpu-rasterization/fast/images/color-profile-background-image-cover.html
> [ NeedsManualRebaseline ]
> crbug.com/627844
> virtual/gpu-rasterization/fast/images/color-profile-object.html [
> NeedsManualRebaseline ]
> crbug.com/627844
> virtual/gpu-rasterization/fast/images/ycbcr-with-cmyk-color-profile.html [
> NeedsManualRebaseline ]
> -crbug.com/627844
> virtual/gpu/fast/canvas/canvas-createImageBitmap-colorClamping.html [ Pass
> Failure ]
> \ No newline at end of file
> +crbug.com/627844
> virtual/gpu/fast/canvas/canvas-createImageBitmap-colorClamping.html [ Pass
> Failure ]
> Index: third_party/WebKit/LayoutTests/WPTServeExpectations
> diff --git a/third_party/WebKit/LayoutTests/WPTServeExpectations
> b/third_party/WebKit/LayoutTests/WPTServeExpectations
> index
>
3ac88330f0c9b4e38de96010dcfbc86c9c971570..474a6c47b033cdf60d277ceaae76527819caae1c
> 100644
> --- a/third_party/WebKit/LayoutTests/WPTServeExpectations
> +++ b/third_party/WebKit/LayoutTests/WPTServeExpectations
> @@ -44,7 +44,6 @@ crbug.com/508725
> imported/wpt/html/webappapis/system-state-and-capabilities/the-
> # Expectation is [ Pass ] since for these there is no -expected.txt,
> # but instead there is a [ Failure ] expectation in TestExpectations.
> crbug.com/508725
>
imported/wpt/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script.html
> [ Pass ]
> -crbug.com/508725
> imported/wpt/mediacapture-streams/GUM-trivial-constraint.https.html [ Pass ]
> crbug.com/508725 imported/wpt/pointerevents/pointerevent_constructor.html
> [ Pass ]
>
> # These tests timeout with --enable-wptserve enabled.
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[qyearsley, 2016-07-15 15:19:32]

On 2016/07/15 at 08:49:58, chromium-reviews wrote:
> Lgtm

Hm, it looks like that LGTM didn't count -- Harald, could you try again after
logging in with Chromium account?

[hta - Chromium, 2016-07-15 19:23:12]

lgtm

[hta - Chromium, 2016-07-15 19:24:24]

The CQ bit was checked by hta@chromium.org

[commit-bot: I haz the power, 2016-07-15 19:25:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 19:30:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-15 19:30:49]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 19:33:16]

Description was changed from

==========
Remove failing expectation for layout test GUM-trivial-constraint.https.html.

Reason: This test seems to be passing consistently now, both on the waterfall
and on my machine.

BUG=412381,508725
==========

to

==========
Remove failing expectation for layout test GUM-trivial-constraint.https.html.

Reason: This test seems to be passing consistently now, both on the waterfall
and on my machine.

BUG=412381,508725

Committed: https://crrev.com/fc28338d5f0794c276f7f4bb6f3a3b15c076a77f
Cr-Commit-Position: refs/heads/master@{#405822}
==========

[commit-bot: I haz the power, 2016-07-15 19:33:17]

Patchset 1 (id:??) landed as
https://crrev.com/fc28338d5f0794c276f7f4bb6f3a3b15c076a77f
Cr-Commit-Position: refs/heads/master@{#405822}