fix #26782, add no-implicit-casts, no-implicit-dynamic options

add no-implicit-casts and no-implicit-dynamic options

* adds these to dartanalyzer command line
* adds them to .analysis_options

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/4b3c06f3c53785aabc116bfdd6ba005033ab3748

[Jennifer Messerly, 2016-07-14 22:12:12]

jmesserly@google.com changed reviewers:
+ leafp@google.com, paulberry@google.com

[Jennifer Messerly, 2016-07-14 22:12:13]

Hi Paul & Leaf, here's the new options we discussed earlier.

The flags are documented here:
--no-implicit-casts: https://goo.gl/cTLz40
--no-implicit-dynamic: https://goo.gl/m0UgXD

in analysis_options it looks like:

analyzer:
  strong-mode:
    implicit-casts: false
    implicit-dynamic: false

I tied these to "strong-mode" as that seemed to fit the existing patterns in the
analysis_options YAML, where sub items are nested under sections like "language"
and "errors". The other place they could've reasonably gone is under "language".

(implicit-dynamic technically doesn't require strong-mode, although in practice,
it doesn't seem very useful without inference.)

`strong-mode: true` is still supported, naturally.

https://github.com/dart-lang/sdk/issues/26782 is tracking bug for this.

[Jennifer Messerly, 2016-07-14 22:14:26]

On 2016/07/14 22:12:13, John Messerly wrote:
> Hi Paul & Leaf, here's the new options we discussed earlier.
> 
> The flags are documented here:
> --no-implicit-casts: https://goo.gl/cTLz40
> --no-implicit-dynamic: https://goo.gl/m0UgXD
> 
> in analysis_options it looks like:
> 
> analyzer:
>   strong-mode:
>     implicit-casts: false
>     implicit-dynamic: false
> 
> I tied these to "strong-mode" as that seemed to fit the existing patterns in
the
> analysis_options YAML, where sub items are nested under sections like
"language"
> and "errors". The other place they could've reasonably gone is under
"language".
> 
> (implicit-dynamic technically doesn't require strong-mode, although in
practice,
> it doesn't seem very useful without inference.)
> 
> `strong-mode: true` is still supported, naturally.
> 
> https://github.com/dart-lang/sdk/issues/26782 is tracking bug for this.

Also BTW, I tested both of these against DDC. Results look reasonable in the
IDE/command line. Amusingly, >350 implicit casts and >550 implicit dynamic, so
an auto-fixup tool is starting to seem like a good idea. :)

[Leaf, 2016-07-14 22:50:37]

lgtm

[Jennifer Messerly, 2016-07-15 23:08:21]

Description was changed from

==========
add no-implicit-casts and no-implicit-dynamic options

* adds these to dartanalyzer command line
* adds them to .analysis_options
==========

to

==========
add no-implicit-casts and no-implicit-dynamic options

* adds these to dartanalyzer command line
* adds them to .analysis_options

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4b3c06f3c53785aabc116bfdd6ba005033ab3748
==========

[Jennifer Messerly, 2016-07-15 23:08:23]

Committed patchset #2 (id:20001) manually as
4b3c06f3c53785aabc116bfdd6ba005033ab3748 (presubmit successful).