Plumbing for login apps device policy to extensions.

chrome/browser/extensions/extension_management_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_management.h"
 
 #include <algorithm>
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/json/json_parser.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_management_internal.h"
 #include "chrome/browser/extensions/extension_management_test_util.h"
 #include "chrome/browser/extensions/external_policy_loader.h"
 #include "chrome/browser/extensions/standard_management_policy_provider.h"
-#include "components/prefs/pref_registry_simple.h"
-#include "components/prefs/testing_pref_service.h"
+#include "chrome/test/base/testing_profile.h"
+#include "components/sync_preferences/testing_pref_service_syncable.h"
+#include "content/public/test/test_browser_thread_bundle.h"
 #include "extensions/browser/pref_names.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/permissions/api_permission.h"
 #include "extensions/common/permissions/permissions_info.h"
 #include "extensions/common/url_pattern.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace extensions {
@@ skipping 39 matching lines @@
     "    \"installation_mode\": \"blocked\","
     "    \"install_sources\": [\"*://foo.com/*\"],"
     "    \"allowed_types\": [\"theme\", \"user_script\"],"
     "    \"blocked_permissions\": [\"fileSystem\", \"downloads\"],"
     "  },"
     "}";
 
 }  // namespace
 
 class ExtensionManagementServiceTest : public testing::Test {
- public:
-  typedef ExtensionManagementPrefUpdater<TestingPrefServiceSimple> PrefUpdater;
+ protected:
+  using PrefUpdater = ExtensionManagementPrefUpdater<
+      sync_preferences::TestingPrefServiceSyncable>;
 
-  ExtensionManagementServiceTest() {}
-  ~ExtensionManagementServiceTest() override {}
+  ExtensionManagementServiceTest() = default;
+  ~ExtensionManagementServiceTest() override = default;
 
   // testing::Test:
-  void SetUp() override { InitPrefService(); }
-
-  void InitPrefService() {
-    extension_management_.reset();
-    pref_service_.reset(new TestingPrefServiceSimple());
-    pref_service_->registry()->RegisterListPref(
-        pref_names::kAllowedInstallSites);
-    pref_service_->registry()->RegisterListPref(pref_names::kAllowedTypes);
-    pref_service_->registry()->RegisterListPref(pref_names::kInstallDenyList);
-    pref_service_->registry()->RegisterListPref(pref_names::kInstallAllowList);
-    pref_service_->registry()->RegisterDictionaryPref(
-        pref_names::kInstallForceList);
-    pref_service_->registry()->RegisterDictionaryPref(
-        pref_names::kExtensionManagement);
-    extension_management_.reset(new ExtensionManagement(pref_service_.get()));
+  void SetUp() override {
+    profile_ = base::MakeUnique<TestingProfile>();
+    pref_service_ = profile_->GetTestingPrefService();
+    extension_management_ =
+        base::MakeUnique<ExtensionManagement>(profile_.get());
   }
 
   void SetPref(bool managed, const char* path, base::Value* value) {
     if (managed)
       pref_service_->SetManagedPref(path, value);
     else
       pref_service_->SetUserPref(path, value);
   }
 
   void RemovePref(bool managed, const char* path) {
@@ skipping 34 matching lines @@
 
   APIPermissionSet GetBlockedAPIPermissionsByUpdateUrl(
       const std::string& update_url) {
     return GetBlockedAPIPermissions(kNonExistingExtension, update_url);
   }
 
   void SetExampleDictPref() {
     std::string error_msg;
     std::unique_ptr<base::Value> parsed = base::JSONReader::ReadAndReturnError(
         kExampleDictPreference,
-        base::JSONParserOptions::JSON_ALLOW_TRAILING_COMMAS, NULL, &error_msg);
+        base::JSONParserOptions::JSON_ALLOW_TRAILING_COMMAS, nullptr,
+        &error_msg);
     ASSERT_TRUE(parsed && parsed->IsType(base::Value::Type::DICTIONARY))
         << error_msg;
     SetPref(true, pref_names::kExtensionManagement, parsed.release());
   }
 
   // Wrapper of ExtensionManagement::GetInstallationMode, |id| and
   // |update_url| are used to construct an Extension for testing.
   ExtensionManagement::InstallationMode GetInstallationMode(
       const std::string& id,
       const std::string& update_url) {
@@ skipping 18 matching lines @@
         CreateExtension(Manifest::UNPACKED, version, id, kNonExistingUpdateUrl);
     std::string minimum_version_required;
     bool ret = extension_management_->CheckMinimumVersion(
         extension.get(), &minimum_version_required);
     EXPECT_EQ(ret, minimum_version_required.empty());
     EXPECT_EQ(ret, extension_management_->CheckMinimumVersion(extension.get(),
                                                               nullptr));
     return ret;
   }
 
- protected:
-  std::unique_ptr<TestingPrefServiceSimple> pref_service_;
+  content::TestBrowserThreadBundle thread_bundle_;
+  std::unique_ptr<TestingProfile> profile_;
+  sync_preferences::TestingPrefServiceSyncable* pref_service_ = nullptr;
   std::unique_ptr<ExtensionManagement> extension_management_;
 
  private:
   // Create an extension with specified |location|, |version|, |id| and
   // |update_url|.
   scoped_refptr<const Extension> CreateExtension(
       Manifest::Location location,
       const std::string& version,
       const std::string& id,
       const std::string& update_url) {
@@ skipping 316 matching lines @@
             GetBlockedAPIPermissions(kTargetExtension3, kExampleUpdateUrl));
 }
 
 // Tests the 'minimum_version_required' settings of extension management.
 TEST_F(ExtensionManagementServiceTest, kMinimumVersionRequired) {
   EXPECT_TRUE(CheckMinimumVersion(kTargetExtension, "0.0"));
   EXPECT_TRUE(CheckMinimumVersion(kTargetExtension, "3.0.0"));
   EXPECT_TRUE(CheckMinimumVersion(kTargetExtension, "9999.0"));
 
   {
-    PrefUpdater pref(pref_service_.get());
+    PrefUpdater pref(pref_service_);
     pref.SetMinimumVersionRequired(kTargetExtension, "3.0");
   }
 
   EXPECT_FALSE(CheckMinimumVersion(kTargetExtension, "0.0"));
   EXPECT_FALSE(CheckMinimumVersion(kTargetExtension, "2.99"));
   EXPECT_TRUE(CheckMinimumVersion(kTargetExtension, "3.0.0"));
   EXPECT_TRUE(CheckMinimumVersion(kTargetExtension, "3.0.1"));
   EXPECT_TRUE(CheckMinimumVersion(kTargetExtension, "4.0"));
 }
 
 // Tests functionality of new preference as to deprecate legacy
 // ExtensionInstallSources policy.
 TEST_F(ExtensionManagementServiceTest, NewInstallSources) {
   // Set the legacy preference, and verifies that it works.
   base::ListValue allowed_sites_pref;
   allowed_sites_pref.AppendString("https://www.example.com/foo");
   SetPref(
       true, pref_names::kAllowedInstallSites, allowed_sites_pref.DeepCopy());
   EXPECT_TRUE(ReadGlobalSettings()->has_restricted_install_sources);
   EXPECT_TRUE(ReadGlobalSettings()->install_sources.MatchesURL(
       GURL("https://www.example.com/foo")));
 
   // Set the new dictionary preference.
   {
-    PrefUpdater updater(pref_service_.get());
+    PrefUpdater updater(pref_service_);
     updater.ClearInstallSources();
   }
   // Verifies that the new one overrides the legacy ones.
   EXPECT_TRUE(ReadGlobalSettings()->has_restricted_install_sources);
   EXPECT_FALSE(ReadGlobalSettings()->install_sources.MatchesURL(
       GURL("https://www.example.com/foo")));
 
   // Updates the new dictionary preference.
   {
-    PrefUpdater updater(pref_service_.get());
+    PrefUpdater updater(pref_service_);
     updater.AddInstallSource("https://corp.mycompany.com/*");
   }
   EXPECT_TRUE(ReadGlobalSettings()->has_restricted_install_sources);
   EXPECT_TRUE(ReadGlobalSettings()->install_sources.MatchesURL(
       GURL("https://corp.mycompany.com/entry")));
 }
 
 // Tests functionality of new preference as to deprecate legacy
 // ExtensionAllowedTypes policy.
 TEST_F(ExtensionManagementServiceTest, NewAllowedTypes) {
   // Set the legacy preference, and verifies that it works.
   base::ListValue allowed_types_pref;
   allowed_types_pref.AppendInteger(Manifest::TYPE_USER_SCRIPT);
   SetPref(true, pref_names::kAllowedTypes, allowed_types_pref.DeepCopy());
   EXPECT_TRUE(ReadGlobalSettings()->has_restricted_allowed_types);
   EXPECT_EQ(ReadGlobalSettings()->allowed_types.size(), 1u);
   EXPECT_EQ(ReadGlobalSettings()->allowed_types[0], Manifest::TYPE_USER_SCRIPT);
 
   // Set the new dictionary preference.
   {
-    PrefUpdater updater(pref_service_.get());
+    PrefUpdater updater(pref_service_);
     updater.ClearAllowedTypes();
   }
   // Verifies that the new one overrides the legacy ones.
   EXPECT_TRUE(ReadGlobalSettings()->has_restricted_allowed_types);
   EXPECT_EQ(ReadGlobalSettings()->allowed_types.size(), 0u);
 
   // Updates the new dictionary preference.
   {
-    PrefUpdater updater(pref_service_.get());
+    PrefUpdater updater(pref_service_);
     updater.AddAllowedType("theme");
   }
   EXPECT_TRUE(ReadGlobalSettings()->has_restricted_allowed_types);
   EXPECT_EQ(ReadGlobalSettings()->allowed_types.size(), 1u);
   EXPECT_EQ(ReadGlobalSettings()->allowed_types[0], Manifest::TYPE_THEME);
 }
 
 // Tests functionality of new preference as to deprecate legacy
 // ExtensionInstallBlacklist policy.
 TEST_F(ExtensionManagementServiceTest, NewInstallBlacklist) {
   // Set the new dictionary preference.
   {
-    PrefUpdater updater(pref_service_.get());
+    PrefUpdater updater(pref_service_);
     updater.SetBlacklistedByDefault(false);  // Allowed by default.
     updater.SetIndividualExtensionInstallationAllowed(kTargetExtension, false);
     updater.ClearPerExtensionSettings(kTargetExtension2);
   }
   EXPECT_FALSE(extension_management_->BlacklistedByDefault());
   EXPECT_EQ(GetInstallationModeById(kTargetExtension),
             ExtensionManagement::INSTALLATION_BLOCKED);
   EXPECT_EQ(GetInstallationModeById(kNonExistingExtension),
             ExtensionManagement::INSTALLATION_ALLOWED);
 
@@ skipping 15 matching lines @@
             ExtensionManagement::INSTALLATION_BLOCKED);
   EXPECT_EQ(GetInstallationModeById(kNonExistingExtension),
             ExtensionManagement::INSTALLATION_ALLOWED);
 }
 
 // Tests functionality of new preference as to deprecate legacy
 // ExtensionInstallWhitelist policy.
 TEST_F(ExtensionManagementServiceTest, NewInstallWhitelist) {
   // Set the new dictionary preference.
   {
-    PrefUpdater updater(pref_service_.get());
+    PrefUpdater updater(pref_service_);
     updater.SetBlacklistedByDefault(true);  // Disallowed by default.
     updater.SetIndividualExtensionInstallationAllowed(kTargetExtension, true);
     updater.ClearPerExtensionSettings(kTargetExtension2);
   }
   EXPECT_TRUE(extension_management_->BlacklistedByDefault());
   EXPECT_EQ(GetInstallationModeById(kTargetExtension),
             ExtensionManagement::INSTALLATION_ALLOWED);
   EXPECT_EQ(GetInstallationModeById(kNonExistingExtension),
             ExtensionManagement::INSTALLATION_BLOCKED);
 
@@ skipping 20 matching lines @@
 // ExtensionInstallForcelist policy.
 TEST_F(ExtensionManagementServiceTest, NewInstallForcelist) {
   // Set some legacy preferences, to verify that the new one overrides the
   // legacy ones.
   base::ListValue denied_list_pref;
   denied_list_pref.AppendString(kTargetExtension);
   SetPref(true, pref_names::kInstallDenyList, denied_list_pref.DeepCopy());
 
   // Set the new dictionary preference.
   {
-    PrefUpdater updater(pref_service_.get());
+    PrefUpdater updater(pref_service_);
     updater.SetIndividualExtensionAutoInstalled(
         kTargetExtension, kExampleUpdateUrl, true);
   }
   EXPECT_EQ(GetInstallationModeById(kTargetExtension),
             ExtensionManagement::INSTALLATION_FORCED);
   CheckAutomaticallyInstalledUpdateUrl(kTargetExtension, kExampleUpdateUrl);
   EXPECT_EQ(GetInstallationModeById(kNonExistingExtension),
             ExtensionManagement::INSTALLATION_ALLOWED);
 }
 
@@ skipping 13 matching lines @@
   EXPECT_TRUE(extension_management_->IsInstallationExplicitlyAllowed(allowed));
   EXPECT_TRUE(extension_management_->IsInstallationExplicitlyAllowed(forced));
   EXPECT_TRUE(
       extension_management_->IsInstallationExplicitlyAllowed(recommended));
   EXPECT_FALSE(extension_management_->IsInstallationExplicitlyAllowed(blocked));
   EXPECT_FALSE(
       extension_management_->IsInstallationExplicitlyAllowed(not_specified));
 
   {
     // Set BlacklistedByDefault() to false.
-    PrefUpdater pref(pref_service_.get());
+    PrefUpdater pref(pref_service_);
     pref.SetBlacklistedByDefault(false);
   }
 
   // The result should remain the same.
   EXPECT_TRUE(extension_management_->IsInstallationExplicitlyAllowed(allowed));
   EXPECT_TRUE(extension_management_->IsInstallationExplicitlyAllowed(forced));
   EXPECT_TRUE(
       extension_management_->IsInstallationExplicitlyAllowed(recommended));
   EXPECT_FALSE(extension_management_->IsInstallationExplicitlyAllowed(blocked));
   EXPECT_FALSE(
       extension_management_->IsInstallationExplicitlyAllowed(not_specified));
 }
 
 // Tests the flag value indicating that extensions are blacklisted by default.
 TEST_F(ExtensionAdminPolicyTest, BlacklistedByDefault) {
-  EXPECT_FALSE(BlacklistedByDefault(NULL));
+  EXPECT_FALSE(BlacklistedByDefault(nullptr));
 
   base::ListValue blacklist;
   blacklist.AppendString(kNonExistingExtension);
   EXPECT_FALSE(BlacklistedByDefault(&blacklist));
   blacklist.AppendString("*");
   EXPECT_TRUE(BlacklistedByDefault(&blacklist));
 
   blacklist.Clear();
   blacklist.AppendString("*");
   EXPECT_TRUE(BlacklistedByDefault(&blacklist));
 }
 
 // Tests UserMayLoad for required extensions.
 TEST_F(ExtensionAdminPolicyTest, UserMayLoadRequired) {
   CreateExtension(Manifest::COMPONENT);
-  EXPECT_TRUE(UserMayLoad(NULL, NULL, NULL, NULL, extension_.get(), NULL));
+  EXPECT_TRUE(UserMayLoad(nullptr, nullptr, nullptr, nullptr, extension_.get(),
+                          nullptr));
   base::string16 error;
-  EXPECT_TRUE(UserMayLoad(NULL, NULL, NULL, NULL, extension_.get(), &error));
+  EXPECT_TRUE(UserMayLoad(nullptr, nullptr, nullptr, nullptr, extension_.get(),
+                          &error));
   EXPECT_TRUE(error.empty());
 
   // Required extensions may load even if they're on the blacklist.
   base::ListValue blacklist;
   blacklist.AppendString(extension_->id());
-  EXPECT_TRUE(
-      UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
+  EXPECT_TRUE(UserMayLoad(&blacklist, nullptr, nullptr, nullptr,
+                          extension_.get(), nullptr));
 
   blacklist.AppendString("*");
-  EXPECT_TRUE(
-      UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
+  EXPECT_TRUE(UserMayLoad(&blacklist, nullptr, nullptr, nullptr,
+                          extension_.get(), nullptr));
 }
 
 // Tests UserMayLoad when no blacklist exists, or it's empty.
 TEST_F(ExtensionAdminPolicyTest, UserMayLoadNoBlacklist) {
   CreateExtension(Manifest::INTERNAL);
-  EXPECT_TRUE(UserMayLoad(NULL, NULL, NULL, NULL, extension_.get(), NULL));
+  EXPECT_TRUE(UserMayLoad(nullptr, nullptr, nullptr, nullptr, extension_.get(),
+                          nullptr));
   base::ListValue blacklist;
-  EXPECT_TRUE(
-      UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
+  EXPECT_TRUE(UserMayLoad(&blacklist, nullptr, nullptr, nullptr,
+                          extension_.get(), nullptr));
   base::string16 error;
-  EXPECT_TRUE(
-      UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), &error));
+  EXPECT_TRUE(UserMayLoad(&blacklist, nullptr, nullptr, nullptr,
+                          extension_.get(), &error));
   EXPECT_TRUE(error.empty());
 }
 
 // Tests UserMayLoad for an extension on the whitelist.
 TEST_F(ExtensionAdminPolicyTest, UserMayLoadWhitelisted) {
   CreateExtension(Manifest::INTERNAL);
 
   base::ListValue whitelist;
   whitelist.AppendString(extension_->id());
-  EXPECT_TRUE(
-      UserMayLoad(NULL, &whitelist, NULL, NULL, extension_.get(), NULL));
+  EXPECT_TRUE(UserMayLoad(nullptr, &whitelist, nullptr, nullptr,
+                          extension_.get(), nullptr));
 
   base::ListValue blacklist;
   blacklist.AppendString(extension_->id());
-  EXPECT_TRUE(
-      UserMayLoad(NULL, &whitelist, NULL, NULL, extension_.get(), NULL));
+  EXPECT_TRUE(UserMayLoad(nullptr, &whitelist, nullptr, nullptr,
+                          extension_.get(), nullptr));
   base::string16 error;
-  EXPECT_TRUE(
-      UserMayLoad(NULL, &whitelist, NULL, NULL, extension_.get(), &error));
+  EXPECT_TRUE(UserMayLoad(nullptr, &whitelist, nullptr, nullptr,
+                          extension_.get(), &error));
   EXPECT_TRUE(error.empty());
 }
 
 // Tests UserMayLoad for an extension on the blacklist.
 TEST_F(ExtensionAdminPolicyTest, UserMayLoadBlacklisted) {
   CreateExtension(Manifest::INTERNAL);
 
   // Blacklisted by default.
   base::ListValue blacklist;
   blacklist.AppendString("*");
-  EXPECT_FALSE(
-      UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
+  EXPECT_FALSE(UserMayLoad(&blacklist, nullptr, nullptr, nullptr,
+                           extension_.get(), nullptr));
   base::string16 error;
-  EXPECT_FALSE(
-      UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), &error));
+  EXPECT_FALSE(UserMayLoad(&blacklist, nullptr, nullptr, nullptr,
+                           extension_.get(), &error));
   EXPECT_FALSE(error.empty());
 
   // Extension on the blacklist, with and without wildcard.
   blacklist.AppendString(extension_->id());
-  EXPECT_FALSE(
-      UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
+  EXPECT_FALSE(UserMayLoad(&blacklist, nullptr, nullptr, nullptr,
+                           extension_.get(), nullptr));
   blacklist.Clear();
   blacklist.AppendString(extension_->id());
-  EXPECT_FALSE(
-      UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
+  EXPECT_FALSE(UserMayLoad(&blacklist, nullptr, nullptr, nullptr,
+                           extension_.get(), nullptr));
 
   // With a whitelist. There's no such thing as a whitelist wildcard.
   base::ListValue whitelist;
   whitelist.AppendString("behllobkkfkfnphdnhnkndlbkcpglgmj");
-  EXPECT_FALSE(
-      UserMayLoad(&blacklist, &whitelist, NULL, NULL, extension_.get(), NULL));
+  EXPECT_FALSE(UserMayLoad(&blacklist, &whitelist, nullptr, nullptr,
+                           extension_.get(), nullptr));
   whitelist.AppendString("*");
-  EXPECT_FALSE(
-      UserMayLoad(&blacklist, &whitelist, NULL, NULL, extension_.get(), NULL));
+  EXPECT_FALSE(UserMayLoad(&blacklist, &whitelist, nullptr, nullptr,
+                           extension_.get(), nullptr));
 }
 
 TEST_F(ExtensionAdminPolicyTest, UserMayLoadAllowedTypes) {
   CreateExtension(Manifest::INTERNAL);
-  EXPECT_TRUE(UserMayLoad(NULL, NULL, NULL, NULL, extension_.get(), NULL));
+  EXPECT_TRUE(UserMayLoad(nullptr, nullptr, nullptr, nullptr, extension_.get(),
+                          nullptr));
 
   base::ListValue allowed_types;
-  EXPECT_FALSE(
-      UserMayLoad(NULL, NULL, NULL, &allowed_types, extension_.get(), NULL));
+  EXPECT_FALSE(UserMayLoad(nullptr, nullptr, nullptr, &allowed_types,
+                           extension_.get(), nullptr));
 
   allowed_types.AppendInteger(Manifest::TYPE_EXTENSION);
-  EXPECT_TRUE(
-      UserMayLoad(NULL, NULL, NULL, &allowed_types, extension_.get(), NULL));
+  EXPECT_TRUE(UserMayLoad(nullptr, nullptr, nullptr, &allowed_types,
+                          extension_.get(), nullptr));
 
   CreateHostedApp(Manifest::INTERNAL);
-  EXPECT_FALSE(
-      UserMayLoad(NULL, NULL, NULL, &allowed_types, extension_.get(), NULL));
+  EXPECT_FALSE(UserMayLoad(nullptr, nullptr, nullptr, &allowed_types,
+                           extension_.get(), nullptr));
 
   CreateHostedApp(Manifest::EXTERNAL_POLICY_DOWNLOAD);
-  EXPECT_FALSE(
-      UserMayLoad(NULL, NULL, NULL, &allowed_types, extension_.get(), NULL));
+  EXPECT_FALSE(UserMayLoad(nullptr, nullptr, nullptr, &allowed_types,
+                           extension_.get(), nullptr));
 }
 
 TEST_F(ExtensionAdminPolicyTest, UserMayModifySettings) {
   CreateExtension(Manifest::INTERNAL);
-  EXPECT_TRUE(UserMayModifySettings(extension_.get(), NULL));
+  EXPECT_TRUE(UserMayModifySettings(extension_.get(), nullptr));
   base::string16 error;
   EXPECT_TRUE(UserMayModifySettings(extension_.get(), &error));
   EXPECT_TRUE(error.empty());
 
   CreateExtension(Manifest::EXTERNAL_POLICY_DOWNLOAD);
   error.clear();
-  EXPECT_FALSE(UserMayModifySettings(extension_.get(), NULL));
+  EXPECT_FALSE(UserMayModifySettings(extension_.get(), nullptr));
   EXPECT_FALSE(UserMayModifySettings(extension_.get(), &error));
   EXPECT_FALSE(error.empty());
 }
 
 TEST_F(ExtensionAdminPolicyTest, MustRemainEnabled) {
   CreateExtension(Manifest::EXTERNAL_POLICY_DOWNLOAD);
-  EXPECT_TRUE(MustRemainEnabled(extension_.get(), NULL));
+  EXPECT_TRUE(MustRemainEnabled(extension_.get(), nullptr));
   base::string16 error;
   EXPECT_TRUE(MustRemainEnabled(extension_.get(), &error));
   EXPECT_FALSE(error.empty());
 
   CreateExtension(Manifest::INTERNAL);
   error.clear();
-  EXPECT_FALSE(MustRemainEnabled(extension_.get(), NULL));
+  EXPECT_FALSE(MustRemainEnabled(extension_.get(), nullptr));
   EXPECT_FALSE(MustRemainEnabled(extension_.get(), &error));
   EXPECT_TRUE(error.empty());
 }
 
 }  // namespace extensions