Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2144253002: Remove unused WebFrameClient::hasPendingNavigation method. (Closed)

Created:
4 years, 5 months ago by dcheng
Modified:
4 years, 5 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, tyoshino+watch_chromium.org, yzshen1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused WebFrameClient::hasPendingNavigation method. BUG=none Committed: https://crrev.com/dfc3fca1cf4ed63e0694f31eebae90c0e7a6b2d3 Cr-Commit-Position: refs/heads/master@{#405677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -20 lines) Patch
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
This was added for Mandoline but is no longer in use.
4 years, 5 months ago (2016-07-14 12:22:50 UTC) #2
dglazkov
lgtm
4 years, 5 months ago (2016-07-14 14:58:21 UTC) #4
esprehn
lgtm
4 years, 5 months ago (2016-07-14 16:20:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144253002/1
4 years, 5 months ago (2016-07-15 00:55:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 02:19:16 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 02:19:18 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 02:20:42 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dfc3fca1cf4ed63e0694f31eebae90c0e7a6b2d3
Cr-Commit-Position: refs/heads/master@{#405677}

Powered by Google App Engine
This is Rietveld 408576698