Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2144203002: [turbofan] JSTypedLowering can just look at the type hints. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] JSTypedLowering can just look at the type hints. If --turbo-type-feedback is off, the type hints on the operators will just be kAny, so we don't need to do additional checks in the JSTypedLowering reducer. R=jarin@chromium.org Committed: https://crrev.com/ac50c1ca8dfdb2b7f0ace4de0dbaa413dbe34262 Cr-Commit-Position: refs/heads/master@{#37750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -32 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +21 lines, -25 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-14 08:56:08 UTC) #1
Benedikt Meurer
Hey Jaro, Here's some nice simplification. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-07-14 08:56:35 UTC) #4
Jarin
lgtm
4 years, 5 months ago (2016-07-14 08:57:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144203002/1
4 years, 5 months ago (2016-07-14 09:00:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 09:18:47 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 09:20:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac50c1ca8dfdb2b7f0ace4de0dbaa413dbe34262
Cr-Commit-Position: refs/heads/master@{#37750}

Powered by Google App Engine
This is Rietveld 408576698