Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2144193003:
Add a few more suppressions for failing WebGL 2.0 tests. (Closed)
|
Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 5 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a few more suppressions for failing WebGL 2.0 tests.
BUG=483282, 540543, 586033, 610800, 621178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
R=cwallez@chromium.org
TBR=zmo@chromium.org
NOTRY=true
Committed: https://crrev.com/0db1953fe885efd464c37a23058960992e746ee0
Cr-Commit-Position: refs/heads/master@{#405682}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Removed unnecessary TODO and used more specific bug ID. #Messages
Total messages: 18 (10 generated)
Description was changed from ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 ========== to ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + cwallez@chromium.org, zmo@chromium.org
FYI. I think these should get all the desktop bots on the chromium.gpu.fyi waterfall green again. Will CQ TBR'd and NOTRY once the optional tryservers come back green.
Description was changed from ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org,cwallez@chromium.org ==========
https://codereview.chromium.org/2144193003/diff/1/content/test/gpu/gpu_tests/... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2144193003/diff/1/content/test/gpu/gpu_tests/... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:618: # TODO(kbr): this suppression doesn't seem to be applying, though Note: I just realized that this test was only recently added and due to the long cycle time hasn't reached this bot yet. I'll remove the TODO and undo this change before committing.
On 2016/07/14 at 20:56:23, kbr wrote: > FYI. I think these should get all the desktop bots on the chromium.gpu.fyi waterfall green again. > > Will CQ TBR'd and NOTRY once the optional tryservers come back green. lgtm
Description was changed from ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org,cwallez@chromium.org ========== to ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=cwallez@chromium.org ==========
On 2016/07/14 21:22:46, Corentin Wallez wrote: > On 2016/07/14 at 20:56:23, kbr wrote: > > FYI. I think these should get all the desktop bots on the chromium.gpu.fyi > waterfall green again. > > > > Will CQ TBR'd and NOTRY once the optional tryservers come back green. > > lgtm Thanks. Bots are green. Landing.
Description was changed from ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=cwallez@chromium.org ========== to ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=cwallez@chromium.org NOTRY=true ==========
Description was changed from ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=cwallez@chromium.org NOTRY=true ========== to ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=cwallez@chromium.org TBR=zmo@chromium.org NOTRY=true ==========
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from cwallez@chromium.org Link to the patchset: https://codereview.chromium.org/2144193003/#ps20001 (title: "Removed unnecessary TODO and used more specific bug ID.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=cwallez@chromium.org TBR=zmo@chromium.org NOTRY=true ========== to ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=cwallez@chromium.org TBR=zmo@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=cwallez@chromium.org TBR=zmo@chromium.org NOTRY=true ========== to ========== Add a few more suppressions for failing WebGL 2.0 tests. BUG=483282, 540543, 586033, 610800, 621178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=cwallez@chromium.org TBR=zmo@chromium.org NOTRY=true Committed: https://crrev.com/0db1953fe885efd464c37a23058960992e746ee0 Cr-Commit-Position: refs/heads/master@{#405682} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0db1953fe885efd464c37a23058960992e746ee0 Cr-Commit-Position: refs/heads/master@{#405682}
Message was sent while issue was closed.
On 2016/07/15 at 02:33:50, commit-bot wrote: > Patchset 2 (id:??) landed as https://crrev.com/0db1953fe885efd464c37a23058960992e746ee0 > Cr-Commit-Position: refs/heads/master@{#405682} Thanks for tackling this! |
