Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2144183002: Revert "Avoid creating weak cells for literal arrays that are empty of literals." (Closed)

Created:
4 years, 5 months ago by mvstanton
Modified:
4 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Avoid creating weak cells for literal arrays that are empty of literals." This fix was made to address a performance issue in memory.long_running_idle_gmail_tbmv2, but it didn't improve things. BUG=615831 Committed: https://crrev.com/7da90ac408d6ab8fc23ec2b5ae62b3c0065cf354 Cr-Commit-Position: refs/heads/master@{#37746}

Patch Set 1 #

Patch Set 2 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -170 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 1 chunk +1 line, -17 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 1 chunk +1 line, -19 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 1 chunk +1 line, -18 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 1 chunk +1 line, -16 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 1 chunk +1 line, -15 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 1 chunk +1 line, -18 lines 0 comments Download
M src/builtins/x87/builtins-x87.cc View 1 1 chunk +1 line, -18 lines 0 comments Download
M src/objects.cc View 4 chunks +13 lines, -36 lines 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +5 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mvstanton
Hi Michael, I'll revert this fix from last month, as it didn't really improve performance ...
4 years, 5 months ago (2016-07-14 07:06:30 UTC) #3
Michael Starzinger
LGTM. Awesome. Thanks!
4 years, 5 months ago (2016-07-14 08:10:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144183002/20001
4 years, 5 months ago (2016-07-14 08:12:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 08:15:55 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 08:15:57 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 08:17:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7da90ac408d6ab8fc23ec2b5ae62b3c0065cf354
Cr-Commit-Position: refs/heads/master@{#37746}

Powered by Google App Engine
This is Rietveld 408576698