Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2144173002: Revert of Flip main remaining Win builders to GN. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
brettw, brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@clean_up_deleted_builders
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip main remaining Win builders to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2139833002/ ) Reason for revert: Build failures on the win and win64 official builders :( See crbug.com/628056 and crbug.com/628055 Original issue's description: > Flip main remaining Win builders to GN. > > Specifically: > > - chromium > - Win > - chromium.perf > - Win Builder > - official.desktop > - win > - win64 > - official.desktop.continuous > - win trunk > > There are still various FYI and memory builders on GYP, as well as > the GYP builders on the chromium.win waterfall. > > R=brucedawson@chromium.org, brettw@chromium.org > BUG=623659 > > Committed: https://crrev.com/8524d4afab4f543f93d53f6e97c3c4e03502bfbd > Cr-Commit-Position: refs/heads/master@{#405178} TBR=brettw@chromium.org,brucedawson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623659 Committed: https://crrev.com/035316cc9a551e6226c283bb348dc6cc19a27b08 Cr-Commit-Position: refs/heads/master@{#405386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M tools/mb/mb_config.pyl View 8 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
Created Revert of Flip main remaining Win builders to GN.
4 years, 5 months ago (2016-07-14 01:20:49 UTC) #2
brettw
lgtm
4 years, 5 months ago (2016-07-14 01:21:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144173002/1
4 years, 5 months ago (2016-07-14 01:21:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 01:24:11 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 01:24:12 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 01:27:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/035316cc9a551e6226c283bb348dc6cc19a27b08
Cr-Commit-Position: refs/heads/master@{#405386}

Powered by Google App Engine
This is Rietveld 408576698